Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update A Simple Game #228

Merged
merged 17 commits into from
Sep 7, 2024
Merged

Update A Simple Game #228

merged 17 commits into from
Sep 7, 2024

Conversation

raeleus
Copy link
Contributor

@raeleus raeleus commented Aug 31, 2024

This PR updates the "A Simple Game" tutorial to reflect the recent changes in project setup app and makes it a lot easier for beginners to follow. It's a complete rewrite featuring new assets, methodologies, and even has a live demo. The goal is to encourage new users to use good practices from the beginning. This will serve as the foundation for revisions to "Extending the Simple Game" and other future tutorials.

  • We now have the rights to all the included assets, so there is no need to link licensed, external sources. I drew the images, recorded the drop sound, and paid a musician for the music.
  • I want the live demo to be 800x500, but I couldn't quite figure out how to do that. It looks slightly ugly from scaling.
  • My wife is not a programmer. She was able to follow this tutorial on her own without my intervention. This contrasts with the previous version she tried before. She was really stuck on that one.
  • I think it's about as long as the previous version. I'd really prefer to have it split on multiple pages, but I think it's fine as is for now.

Please test this tutorial and give me your thoughts. I aim to make a video on this tutorial in October. Thanks everyone!

Copy link
Member

@tommyettinger tommyettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find any typos! Huzzah. The assets look great, I'm glad they're part of the libGDX wiki now, and I only have some minor suggestions for ways to clarify things that might trip up new users. In general the tutorial looks quite solid!

assets/images/dev/a-simple-game/11.png Outdated Show resolved Hide resolved
assets/images/dev/a-simple-game/1.png Outdated Show resolved Hide resolved
assets/downloads/tutorials/simple-game/background.png Outdated Show resolved Hide resolved
assets/images/dev/a-simple-game/15.png Outdated Show resolved Hide resolved
wiki/start/a-simple-game.md Outdated Show resolved Hide resolved
wiki/start/a-simple-game.md Outdated Show resolved Hide resolved
wiki/start/a-simple-game.md Outdated Show resolved Hide resolved
wiki/start/a-simple-game.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Frosty-J Frosty-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the game. Here follows my stream of consciousness as I went through it. For the most part, I am not requesting changes.

wiki/start/a-simple-game.md Show resolved Hide resolved
wiki/start/a-simple-game.md Outdated Show resolved Hide resolved
wiki/start/a-simple-game.md Outdated Show resolved Hide resolved
wiki/start/a-simple-game.md Outdated Show resolved Hide resolved
wiki/start/a-simple-game.md Show resolved Hide resolved
wiki/start/a-simple-game.md Show resolved Hide resolved
wiki/start/a-simple-game.md Outdated Show resolved Hide resolved
wiki/start/a-simple-game.md Outdated Show resolved Hide resolved

float delta = Gdx.graphics.getDeltaTime();
//Apply the bucket position and size to the bucketRectangle
bucketRectangle.set(bucketSprite.getX(), bucketSprite.getY(), bucketWidth, bucketHeight);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point you gave up on using ... to avoid repeating entire methods throughout the tutorial, huh? I find it difficult to not just copy and paste the entire method, learning nothing, when I can't clearly see what has changed. Partly to blame is the dull comments syntax highlighting on the wiki.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was struggling with this one. I couldn't decide if I liked it more one way or another. I just remember finding it frustrating as a new programmer that samples omitted too much code and expected me to know what they were asking.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better for the code to be present if new users are the target audience.

wiki/start/a-simple-game.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Frosty-J Frosty-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big changes. Must be good.

@raeleus
Copy link
Contributor Author

raeleus commented Sep 4, 2024

Thanks everyone for the reviews! This was really helpful. I'll leave this up for a little bit longer to see if anyone wants to comment on the latest changes, but I think it's in really good shape!

wiki/start/a-simple-game.md Outdated Show resolved Hide resolved
@raeleus raeleus merged commit 6448fff into libgdx:dev Sep 7, 2024
@raeleus
Copy link
Contributor Author

raeleus commented Sep 7, 2024

Okay, it's up folks. If any other tweaks are needed, I'll just modify the page directly. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants