-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update A Simple Game #228
Update A Simple Game #228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find any typos! Huzzah. The assets look great, I'm glad they're part of the libGDX wiki now, and I only have some minor suggestions for ways to clarify things that might trip up new users. In general the tutorial looks quite solid!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made the game. Here follows my stream of consciousness as I went through it. For the most part, I am not requesting changes.
|
||
float delta = Gdx.graphics.getDeltaTime(); | ||
//Apply the bucket position and size to the bucketRectangle | ||
bucketRectangle.set(bucketSprite.getX(), bucketSprite.getY(), bucketWidth, bucketHeight); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point you gave up on using ...
to avoid repeating entire methods throughout the tutorial, huh? I find it difficult to not just copy and paste the entire method, learning nothing, when I can't clearly see what has changed. Partly to blame is the dull comments syntax highlighting on the wiki.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was struggling with this one. I couldn't decide if I liked it more one way or another. I just remember finding it frustrating as a new programmer that samples omitted too much code and expected me to know what they were asking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better for the code to be present if new users are the target audience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big changes. Must be good.
Thanks everyone for the reviews! This was really helpful. I'll leave this up for a little bit longer to see if anyone wants to comment on the latest changes, but I think it's in really good shape! |
Okay, it's up folks. If any other tweaks are needed, I'll just modify the page directly. Thanks everyone! |
This PR updates the "A Simple Game" tutorial to reflect the recent changes in project setup app and makes it a lot easier for beginners to follow. It's a complete rewrite featuring new assets, methodologies, and even has a live demo. The goal is to encourage new users to use good practices from the beginning. This will serve as the foundation for revisions to "Extending the Simple Game" and other future tutorials.
Please test this tutorial and give me your thoughts. I aim to make a video on this tutorial in October. Thanks everyone!