Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepared geometry is not thread-safe #825

Open
dbaston opened this issue Feb 14, 2023 · 1 comment
Open

Prepared geometry is not thread-safe #825

dbaston opened this issue Feb 14, 2023 · 1 comment
Milestone
3.14.0

Comments

@dbaston
Copy link
Member

dbaston commented Feb 14, 2023

The current prepared geometry implementations are not thread safe. In dbaston@c196055 I updated the various lazy initialization methods of PreparedPolygon to use std::call_once. Running a multi-threaded test under valgrind --tool=helgrind shows problems in MCIndexSegmentSetMutualIntersector. There is a lot of state manipulation this class that would need to be removed, while remaining within (or updating) the SegmentSetMutualIntersector interface.
@dbaston
Copy link
Member Author

dbaston commented Feb 16, 2023

PR: #826

@pramsey pramsey added this to the 3.13.0 milestone Jun 7, 2023
This was referenced Sep 4, 2024
Open
Open
@pramsey pramsey modified the milestones: 3.13.0, 3.14.0 Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.14.0
Development

No branches or pull requests
2 participants
@pramsey @dbaston