Make prepared geometry (more?) thread-safe #826
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes prepared geometries thread-safe, or at least more thread safe than they used to be. The clang thread sanitizer reports no errors on the included test.
valgrind --tool=helgrind
reports many, but I'm wondering it isn't correctly understanding thestd::call_once
construct.This introduces a few number of inconsistencies with JTS. I think they are pretty minor.
MonotoneChain::getEnvelope
no longer takes anexpansionDistance
argument. That distance is now provided toMonotoneChainBuilder
, and the envelopes are eagerly constructed. The previous handling of this parameter was arguably incorrect, in any case.MCIndexSegmentSetMutualIntersector::process
can now accept aSegmentIntersector
argument so that multiple threads can callprocess
with their ownSegmentIntersector
. I did not change the entireSegmentSetMutualIntersector
interface, just this one class.FastSegmentSetIntersector
no longer shares aLineIntersector
between calls.IndexedPointInAreaLocator
eagerly builds its index. This should be OK since the locator itself is (usually?) lazily-constructed.I haven't yet done performance testing to see if there is a penalty for single-threaded uses.