Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEOSDensify: Interpolate Z coordinate #1094

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

vadimcn
Copy link
Contributor

@vadimcn vadimcn commented May 12, 2024

New vertices created by GEOSDensify set Z coordinate to NAN, even if the original geometry has a valid Z.
This PR resolves the issue.

@dbaston
Copy link
Member

dbaston commented May 13, 2024

Can you please list this under "Fixes/Improvements" in NEWS.md ?

@dr-jts
Copy link
Contributor

dr-jts commented May 13, 2024

Can you please list this under "Fixes/Improvements" in NEWS.md ?

I usually keep NEWS updates separate from PRs, to allow easy cherry-picking backwards.

@dr-jts dr-jts added the Enhancement New feature or feature improvement. label May 13, 2024
@dbaston
Copy link
Member

dbaston commented May 15, 2024

I usually keep NEWS updates separate from PRs, to allow easy cherry-picking backwards.

It can be a separate commit (although I don't plan to backport this), but if @vadimcn wants the changes credited to their name, I'll need them to put it in the NEWS file.

@dbaston dbaston merged commit 7d9ebd7 into libgeos:main May 15, 2024
30 checks passed
@vadimcn vadimcn deleted the fix-GEOSDensify branch May 15, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or feature improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants