credentials: provide backcompat for opaque structs #5465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The credential structures are now opaque and defined in `sys/credential.h`. However, we should continue to provide them for backward compatibility, unless `GIT_DEPRECATED_HARD` is set.
pks-t
approved these changes
Mar 26, 2020
| * definition has moved into the `sys/credential.h` header; include | ||
| * them here for backward compatibility. | ||
| */ | ||
| #include "sys/credential.h" |
There was a problem hiding this comment.
I thought of adding these headers to "include/git2/credential.h", but this is definitely the better location to have it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The credential structures are now opaque and defined in
sys/credential.h. However, we should continue to provide them for backward compatibility, unlessGIT_DEPRECATED_HARDis set.Fixes #5415