Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #5511

Merged
merged 1 commit into from
May 12, 2020
Merged

Update package.json #5511

merged 1 commit into from
May 12, 2020

Conversation

suhaibmujahid
Copy link
Contributor

Change the outdated version in the package.json file to the current version.

@pks-t
Copy link
Member

pks-t commented May 11, 2020

Thanks a lot for updating this! Honestly, my first reaction is to just remove the file altogether as seemingly not a lot of people care. If they did, we would've gotten complaints earlier. But you doing the update may indicate that some actually do, so I wonder whether you actually use clib or if this is just something you stumbled over.

If we decide we want to keep it because there are some real users, would you mind also updating scripts/release.py to verify its version matches the new release's version? Like this, we won't forget to update in the future.

@suhaibmujahid
Copy link
Contributor Author

Thank you @pks-t. Actually I don't use clib yet but I was trying it out and I found out that the version is outdated.

I am ready to update scrpts/release.py if you decide to keep the file.

@ethomson
Copy link
Member

Yeah, let's keep this for now. @suhaibmujahid if you want to update the python release script, that would be great!

@ethomson ethomson merged commit 51a2bc4 into libgit2:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants