Compiling under MacOS X does not work

[dragan]

I tried to compile under MacOS X and fix the problems, but there was too many and I just decided to stop and report the issue and some insight of what I've done so far. Basically, I got it compiling, but tests fail or cause mono to crash. To compile, make these changes, by editing your existing *nix toolchain (build.libgit2sharp.sh & CI-build.msbuild) or create new ones just for mac:

1. You need to use DYLD_FALLBACK_LIBRARY_PATH when adding native binaries to Mono's search path for MacOS X.
2. Need to compile libgit2 for 32-bit instead of 64-bit, since the Mono release package for MacOS X is 32-bit only. That or compile your own version of Mono targeting 64-bit.
3. Not sure if this is still needed, but I did it anyways, create a config file so you can set a dllmap. On MacOS X, native binaries end with .dylib instead of .so.
4. You may need to modify how some files are copied around during the build process as well.

After that, it should compile and run the tests, where you'll see the failing tests.

[nulltoken]

@dragan ❤️ for sharing these steps with us!

/cc @ben

[dragan]

@nulltoken @ben You're welcome, I went ahead and created a gist of the changes I mentioned above to help you out.

[ben]

I spent an hour this morning finding out your steps 1 and 2 was necessary. Using dtrace, I found that step 3 wasn't really necessary; apparently Mono is now (as of 3.2.3) correctly looking for *.dylib.

Running a slightly-modified build.libgit2sharp.sh, I was able to get this:

xUnit.net console test runner (32-bit .NET 2.0.50727.1433)
Copyright (C) 2013 Outercurve Foundation.

xunit.dll:     Version 1.9.0.1566
Test assembly: /Users/ben/src/libgit2sharp/LibGit2Sharp.Tests/bin/Debug/LibGit2Sharp.Tests.dll

LibGit2Sharp.Tests.ShadowCopyFixture.CanProbeForNativeBinariesFromAShadowCopiedAssembly [FAIL]
   Assert.True() Failure
   Stack Trace:
     at LibGit2Sharp.Tests.ShadowCopyFixture.CanProbeForNativeBinariesFromAShadowCopiedAssembly () [0x00000] in <filename unknown>:0
     at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)
     at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <filename unknown>:0

LibGit2Sharp.Tests.StageFixture.CanStageANewFileWithAFullPath(ignorecase: True) [SKIP]
   Skipping 'ignorecase = true' test due to ignorecase issue in libgit2.

LibGit2Sharp.Tests.CloneFixture.CanCloneWithCredentials [SKIP]
   Populate Constants.PrivateRepo* to run this test

LibGit2Sharp.Tests.ConflictFixture.CanRetrieveSingleConflictByPath [FAIL]
   System.InvalidOperationException : An exception was thrown while getting data for theory LibGit2Sharp.Tests.ConflictFixture.CanRetrieveSingleConflictByPath:
   System.ArgumentException: Property ConflictData on LibGit2Sharp.Tests.ConflictFixture did not return IEnumerable<object[]>
     at Xunit.Extensions.PropertyDataAttribute.GetData (System.Reflection.MethodInfo methodUnderTest, System.Type[] parameterTypes) [0x00000] in <filename unknown>:0
     at Xunit.Extensions.TheoryAttribute+<GetData>d__7.MoveNext () [0x00000] in <filename unknown>:0
     at Xunit.Extensions.TheoryAttribute.EnumerateTestCommands (IMethodInfo method) [0x00000] in <filename unknown>:0
   Stack Trace:
     at Xunit.Extensions.TheoryAttribute+<>c__DisplayClass5.<EnumerateTestCommands>b__1 () [0x00000] in <filename unknown>:0
     at Xunit.Extensions.TheoryAttribute+LambdaTestCommand.Execute (System.Object testClass) [0x00000] in <filename unknown>:0

LibGit2Sharp.Tests.DiffTreeToTreeFixture.CanDetectTheRenamingOfAModifiedFile [SKIP]
   Not implemented in libgit2 yet.

LibGit2Sharp.Tests.FetchFixture.CanFetchIntoAnEmptyRepositoryWithCredentials [SKIP]
   Populate Constants.PrivateRepo* to run this test

LibGit2Sharp.Tests.BlobFixture.CanReadBlobFilteredStream(autocrlf: "true", expectedContent: "hey there
") [SKIP]
   Non-Windows does not support core.autocrlf = true

LibGit2Sharp.Tests.BlobFixture.CanGetBlobAsFilteredText(autocrlf: "true", expectedText: "hey there
") [SKIP]
   Non-Windows does not support core.autocrlf = true

LibGit2Sharp.Tests.BranchFixture.CanCreateBranch(name: "Ångström") [FAIL]
   Assert.NotNull() Failure
   Stack Trace:
     at LibGit2Sharp.Tests.BranchFixture.CanCreateBranch (System.String name) [0x00000] in <filename unknown>:0
     at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)
     at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <filename unknown>:0

923 total, 3 failed, 6 skipped, took 50.748 seconds

I'm hoping to get some of this resolved (along with my particular issue), and put together a PR that helps that script work properly on OSX, and hopefully make the development situation better.

[nulltoken]

cf. #560