Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK version in global.json #1784

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Update SDK version in global.json #1784

merged 1 commit into from
Apr 15, 2020

Conversation

bording
Copy link
Member

@bording bording commented Apr 15, 2020

The new SDK is required to work with the 16.5 version of Visual Studio 2019.

Fixes #1781

@bording bording merged commit 7fc4be5 into master Apr 15, 2020
@bording bording deleted the update-global-json branch April 15, 2020 23:34
@AArnott
Copy link
Contributor

AArnott commented Apr 15, 2020

I don't object to updating global.json to keep up with the current SDK, but I disagree that VS requires it.

I have VS 16.7 on my box and it loads all the projects just fine. So I don't think we can claim this fixes #1781. If it's the case that we somehow need the 32-bit version of the SDK installed, that might need a different fix.

@bording
Copy link
Member Author

bording commented Apr 15, 2020

If it's the case that we somehow need the 32-bit version of the SDK installed, that might need a different fix.

It's my understanding that VS does not care about the 32-bit SDK. It installs the 64-bit SDK when you install the .NET Core workload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't load projects in solution
2 participants