Add CustomHeaders to PushOptions #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance this could be merged? I'm currently maintaining a custom fork with this but this would allow me to delete it. |
|
I would love to merge it, but it doesn't seem like the maintainers are very active unfortunately. |
|
I also need this :). How can we get it in? |
|
@bording are you going to merge this change soon? |
|
I need this aswell |
|
@James-LG Go ahead and take out the devcontainer stuff, and then I'll give this a review and get it merged and released this weekend. |
Wires up CustomHeaders in PushOptions in the same vain as FetchOptions.
|
Thanks! Devcontainers removed. |
bording
approved these changes
Nov 3, 2023
bording
changed the title
|
This has been released in LibGit2Sharp 0.28.0. |
|
That is awesome @bording. Thanks for taking the time to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wires up CustomHeaders in PushOptions in the same vein as FetchOptions.
Libgit2 already supports CustomerHeaders on PushOptions, so might as well hook it up. Plus it's required for some git servers that require strange PAT token formats like Azure DevOps #2041.
This PR is similar to #2011 except it properly disposes the managed string array and it has some tests.