CommitFilter: add simplify-by-first-parent option#583
Merged
Conversation
Member
There was a problem hiding this comment.
SortBy = CommitSortStrategies.Time;
I know this is completely unrelated to this PR, but shouldn't it be?
SortBy = CommitSortStrategies.Time | CommitSortStrategies.Topological;
Member
Author
There was a problem hiding this comment.
It is redundant, but I figured it was clearer to show it in the constructor, same as we don't rely on the default value for SortBy.
Member
There was a problem hiding this comment.
It is redundant, but I figured it was clearer to show it in the constructor
Fair enough
Member
|
Redundancy aside, 👍 |
LibGit2Sharp/CommitLog.cs
Outdated
Member
|
@carlosmn's on a roll! |
Member
Author
|
Braces added, and @dahlbyk seems ok with leaving the |
Now that this is doable directly inside the revision walker, let's expose it as a possible filter option. This fixes #258.
Member
|
🎱 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that this is doable directly inside the revision walker, let's
expose it as a possible filter option.
This fixes #258.