Make OdbBackend.Read[Prefix]() methods return an UnmanagedMemoryStream #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/cc @synhershko |
|
+1 Also if there could be a way to provide the low-level API with an existing stream or byte array so it can do the copy itself (or let me write directly to it, with no middle man) - all the better |
Member
Author
|
@synhershko Done! Also added a helper function to ease the building of the /cc @phkelley |
|
Awesome, thanks @nulltoken , I'll update and test as soon as its released to nuget |
Member
|
This looks great. Thanks @nulltoken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently those methods return an out
Stream. However, the underlying code expects it to be anUnmanagedMemoryStream.Let's make this explicit through a change in the parameter type rather than silently failing.