Skip to content

Conversation

@Therzok
Copy link
Member

@Therzok Therzok commented Jun 13, 2014

@Therzok
Copy link
Member Author

Therzok commented Jun 13, 2014

This PR handles the API change of remote_rename which returns an array of problems. I'm keeping API from breaking by doing the callback manually on the items.

@Therzok
Copy link
Member Author

Therzok commented Jun 13, 2014

Also this is to get libgit2/libgit2@9c3e4e9 in which contains a pretty huge bugfix for authentication.

@Therzok
Copy link
Member Author

Therzok commented Jun 13, 2014

/cc @nulltoken

@Therzok
Copy link
Member Author

Therzok commented Jun 14, 2014

So, can this be merged?

@nulltoken
Copy link
Member

@Therzok Can you please update the PR to take into account libgit2/libgit2#2421 that's just been merged? I was waiting for it and @vmg was kind enough to let it in.

@Therzok
Copy link
Member Author

Therzok commented Jun 14, 2014

Ah, perfect, I will.

@Therzok Therzok changed the title Update binaries to 9c3e4e9 Update binaries to e93206e Jun 14, 2014
@Therzok
Copy link
Member Author

Therzok commented Jun 14, 2014

Updated.

@nulltoken nulltoken merged commit 6eee53c into libgit2:vNext Jun 14, 2014
@nulltoken
Copy link
Member

Bam! It's in. Thanks!

@nulltoken nulltoken added this to the v0.19.0 milestone Jun 14, 2014
@Therzok Therzok deleted the binariesUpgrade branch June 14, 2014 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants