Introduce StageOptions, IncludeIgnored option
#777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LibGit2Sharp/Index.cs
Outdated
Member
There was a problem hiding this comment.
Old overloads should be retained as [Obsolete].
Member
Author
|
Thanks @dahlbyk , should be all fixed up. |
Member
👌 |
Member
Author
|
@nulltoken, did you have any thoughts on this? |
Member
@ethomson I think I'd rather prefer breaking the behavior and acting more like git.git by default. |
Member
Author
|
@nulltoken Okay, the new behavior is for |
Stage() now respects ignore files by default, similar to git.git. Users accustomed to the old behavior may use the new StageOptions class (in particular the IncludeIgnored bool) to override this behavior.
Member
Author
|
Okay, @nulltoken and @dahlbyk, I corrected the text in the comments. This should be ready for merge! |
Member
|
💥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users of
Stage()who want to pass a glob or a directory may expectStage()to respect ignored files. Add aStageOptionsto allow thisbehavior, but keep the default to including ignored for backcompat.