Xcode 7.3 Support #567

phatblat · 2016-03-24T04:57:33Z

Quick & Nimble

Update Quick & Nimble for Swift 2.2 compatibility. Quick (0.9.2) and Nimble (4.0) contain fixes (Quick/Quick#504 and Quick/Nimble#269) for Swift 2.2.

⚠️ Requires Xcode 7.3. While the framework targets should still build with any version of Xcode 7.0+, the Tests target require 7.3 because these test frameworks won't build with older versions of Swift.

xctool

Due to issues with xctool (such as facebookarchive/xctool#666) with Xcode upgrades, it has been dropped as a build tool.

xcpretty

The cibuild script has been completely overhauled, making it much simpler and more reliable. Instead of xctool, it now uses straight xcodebuild commands with output piped through xcpretty.

When running on Travis, xcpretty-travis-formatter is used to format the the output.

phatblat · 2016-03-24T05:11:47Z

Looks like we've got a valid test failure

  1) -[GTSignatureSpec should_keep_the_git_signature_alive_even_if_the_object_goes_out_of_scope] (ObjectiveGit-MacTests.xctest)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Test crashed while running.

The git_signature is NULL on the last line of this snippet causing initWithGitSignature: to blow up.

it(@"should keep the git_signature alive even if the object goes out of scope", ^{
    const git_signature *git_signature = NULL;

    {
        GTSignature *testSignature __attribute__((objc_precise_lifetime)) = [[GTSignature alloc] initWithName:name email:email time:time];
        git_signature = testSignature.git_signature;
    }

    GTSignature *testSignature = [[GTSignature alloc] initWithGitSignature:git_signature];

This is different in Xcode 7.3. It works fine in 7.2.1.

pietbrauer · 2016-03-24T05:12:25Z

@phatblat I have a patch, will post it in 2 minutes.

phatblat · 2016-03-24T05:22:41Z

xctool 0.2.8 died in the same spot running the iOS tests as we had trouble with it testing Quick on Xcode 7.3. However, the message is different.

[Info] Collecting info for testables... (1234 ms)
2016-03-24 05:18:41.651 xctool[29278:35046] *** Assertion failure in cpu_type_t CpuTypeForTestBundleAtPath(NSString *__strong)(), /tmp/xctool20160208-1139-sj4ed3/xctool-0.2.8/Common/XCToolUtil.m:914
2016-03-24 05:18:41.654 xctool[29278:35046] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Bundle's executable code doesn't support nor i386, nor x86_64 CPU types. Bundle path: /Users/travis/Library/Developer/Xcode/DerivedData/ObjectiveGitFramework-dggdbcqvjtimfddtjpjrzodjcbls/Build/Products/Debug-iphoneos/ObjectiveGit-iOSTests.xctest, supported cpu types: (

Updating xctool to HEAD to see if that gets past this.

pietbrauer · 2016-03-24T08:07:40Z

I released https://github.com/libgit2/objective-git/releases/tag/0.12.0 as carthage build objective-git --no-skip-current is working. This removes a bit of pressure from this PullRequest.

phatblat · 2016-04-02T16:35:09Z

The crashing test - GTSignatureSpec should_keep_the_git_signature_alive_even_if_the_object_goes_out_of_scope - was due to __attribute__((objc_precise_lifetime)) not behaving the same in Xcode 7.3 and Apple LLVM version 7.3.0 (clang-703.0.29). The git_signature was NULL when the 2nd GTSignature was trying to initialize. Removing the attribute causes the test to pass and not crash.

After that, GTOIDSpec should_keep_the_git_oid_alive_even_if_the_object_goes_out_of_scope was failing (no crash). Similarly, removing __attribute__((objc_precise_lifetime)) caused that test to pass as well.

I don't know if I fully understand __attribute__((objc_returns_inner_pointer)), but it sounds like it tells ARC to not release the containing (GT*) object when one of these "interior" pointers is still in scope. Adding __attribute__((objc_precise_lifetime)) sounds like it disables this behavior.

I've removed these two instances of __attribute__((objc_precise_lifetime)) for now.

phatblat · 2016-04-03T17:25:37Z

Something is going wrong in cibuild. I've tested xctool with these changes and it runs fine and the tests pass, but when executed from the cibuild script it's throwing this assertion:

2016-04-03 11:18:03.349 xctool[83039:241514] *** Assertion failure in -[SimulatorInfo systemRootForSimulatedSdk], /tmp/xctool20160323-7546-1p54dmr/xctool/xctool/SimulatorWrapper/SimulatorInfo.m:280
2016-04-03 11:18:03.349 xctool[83039:241514] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Platform 'iphoneos' is not yet supported.'

It looks as if the sdkflags are never getting set. I'm guessing the xctool.awk script is returning 0. I'm going to try simplifying the script to work around this.

pietbrauer · 2016-04-04T15:29:26Z

Nice work. 2 cents:

Rebasing would be nice
I was debating why we still use xctool and not change to xcodebuild and xcpretty which comes standard with Travis.

phatblat · 2016-04-04T15:33:20Z

Sure, I can clean this up and rebase it.

As for xcpretty, I'm game. I ran into some trouble with it and Xcode 7.0 last fall but with all the trouble we've had with xctool, I think it's worth looking into again.

- Quick 0.9.1+ - Nimble 3.2.0+ These resolve many deprecation warnings with Swift 2.2 in Xcode 7.3

- Replaced xctool with xcodebuild + xcpretty - Removed unused cruft and awk scripts

Also enabled fast_finish for builds

phatblat · 2016-04-05T03:49:08Z

Closing/reopening PR to trigger build.

pietbrauer · 2016-04-05T03:50:36Z

.travis.yml

@@ -1,14 +1,17 @@
 osx_image: xcode7
 language: objective-c
 matrix:
+  fast_finish: true:


I think this is why Travis is not starting the build true: should be true

pietbrauer · 2016-04-05T03:51:56Z

Travis smartypants 👍

pietbrauer · 2016-04-05T04:12:38Z

script/cibuild

+  echo "*** Building and testing $SCHEME..."
+  echo
+
+  xcodebuild -workspace "$XCWORKSPACE" \


From the xcpretty docs:

$ set -o pipefail && xcodebuild [flags] | xcpretty # # OR # $ xcodebuild [flags] | xcpretty && exit ${PIPESTATUS[0]}

phatblat · 2016-04-06T01:00:18Z

The build is finally 💚

pietbrauer · 2016-04-06T02:22:43Z

Looks good but waiting for the merge since Nimble 4.0.0 was just released and I suspect a Quick release with Xcode 7.3 support too.

phatblat · 2016-04-06T02:28:26Z

Fine by me. I'd rather be using released versions.

Quick may take a couple days because I just submitted Quick/Nimble#278 to unblock Quick/Quick#507

Falling back to default of iOS 8.0

phatblat · 2016-04-08T03:54:37Z

❌  /Users/travis/build/libgit2/objective-git/ObjectiveGitTests/SwiftSpec.swift:11:8: module file's minimum deployment target is ios9.3 v9.3: /Users/travis/Library/Developer/Xcode/DerivedData/ObjectiveGitFramework-dggdbcqvjtimfddtjpjrzodjcbls/Build/Products/Debug-iphonesimulator/Quick.framework/Modules/Quick.swiftmodule/i386.swiftmodule
import Quick
       ^

It's counter-intuitive, but I think that build failure basically means Xcode is confused because the deployment target isn't 8.0.

phatblat · 2016-04-11T03:43:41Z

Quick and Nimble have been updated. This PR is ready to be merged! 🚀

pietbrauer · 2016-04-11T04:30:00Z

Sweet 👌

pietbrauer self-assigned this Mar 24, 2016

phatblat changed the title ~~Update Quick & Nimble for Swift 2.2 compatibility~~ Xcode 7.3 Support Apr 5, 2016

phatblat added 5 commits April 4, 2016 21:46

Pin Quick and Nimble to commits on master

a3763e4

- Quick 0.9.1+ - Nimble 3.2.0+ These resolve many deprecation warnings with Swift 2.2 in Xcode 7.3

Remove __attribute__((objc_precise_lifetime)) from tests

4792166

Overhaul cibuild

6f802a4

- Replaced xctool with xcodebuild + xcpretty - Removed unused cruft and awk scripts

Install xcpretty on travis

29f5a53

Also enabled fast_finish for builds

Update list of required tools on readme

9145b0a

phatblat force-pushed the ben/quick-nimble branch from 9749d90 to 9145b0a Compare April 5, 2016 03:47

phatblat closed this Apr 5, 2016

phatblat reopened this Apr 5, 2016

pietbrauer reviewed Apr 5, 2016
View reviewed changes

Fix fast_finish in travis file

f434994

pietbrauer reviewed Apr 5, 2016
View reviewed changes

phatblat added 3 commits April 4, 2016 22:19

Configure cibuild to echo commands and fail on first error

7813f12

Enable pipefail

f250c3d

Fix osx_image for Mac build

ede649f

phatblat added 2 commits April 5, 2016 20:55

Nimble 4.0

0261154

Remove iOS 9.0 deployment target from tests

4050ece

Falling back to default of iOS 8.0

Quick 0.9.2

e19fcc4

pietbrauer merged commit 71907ef into libgit2:master Apr 11, 2016

phatblat deleted the ben/quick-nimble branch April 11, 2016 14:50

pietbrauer mentioned this pull request Apr 15, 2016

Use libgit2 0.24.1 #573

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Xcode 7.3 Support #567

Xcode 7.3 Support #567

phatblat commented Mar 24, 2016

phatblat commented Mar 24, 2016

pietbrauer commented Mar 24, 2016

phatblat commented Mar 24, 2016

pietbrauer commented Mar 24, 2016

phatblat commented Apr 2, 2016

phatblat commented Apr 3, 2016

pietbrauer commented Apr 4, 2016

phatblat commented Apr 4, 2016

phatblat commented Apr 5, 2016

pietbrauer Apr 5, 2016

phatblat Apr 5, 2016

pietbrauer commented Apr 5, 2016

pietbrauer Apr 5, 2016

phatblat commented Apr 6, 2016

pietbrauer commented Apr 6, 2016

phatblat commented Apr 6, 2016

phatblat commented Apr 8, 2016

phatblat commented Apr 11, 2016

pietbrauer commented Apr 11, 2016

Xcode 7.3 Support #567

Xcode 7.3 Support #567

Conversation

phatblat commented Mar 24, 2016

Quick & Nimble

xctool

xcpretty

phatblat commented Mar 24, 2016

pietbrauer commented Mar 24, 2016

phatblat commented Mar 24, 2016

pietbrauer commented Mar 24, 2016

phatblat commented Apr 2, 2016

phatblat commented Apr 3, 2016

pietbrauer commented Apr 4, 2016

phatblat commented Apr 4, 2016

phatblat commented Apr 5, 2016

pietbrauer Apr 5, 2016

Choose a reason for hiding this comment

phatblat Apr 5, 2016

Choose a reason for hiding this comment

pietbrauer commented Apr 5, 2016

pietbrauer Apr 5, 2016

Choose a reason for hiding this comment

phatblat commented Apr 6, 2016

pietbrauer commented Apr 6, 2016

phatblat commented Apr 6, 2016

phatblat commented Apr 8, 2016

phatblat commented Apr 11, 2016

pietbrauer commented Apr 11, 2016