virt-install output is missing preseed argument in --extra-args #7
Comments
rwmjones
added a commit
that referenced
this issue
Feb 13, 2025
The same change as in this libguestfs commit: libguestfs/libguestfs@b5fbc7e Also update the common submodule to get: commit 8137d47d0e654065391151eb275e3b64f230f6f5 Author: Richard W.M. Jones <rjones@redhat.com> Date: Thu Feb 13 11:13:55 2025 +0000 mlcustomize, mltools: Replace $TEST_FUNCTIONS TEST_FUNCTIONS is being removed from libguestfs and guestfs-tools (it was removed from virt-v2v a while back). Make the same adjustment in the common submodule. commit a4d620ddef0feee290e72924c245d98952ad3b0c Merge: 2bb8c83 91d89a5 Author: rwmjones <rjones@redhat.com> Date: Wed Feb 12 21:59:29 2025 +0000 Merge pull request #7 from crobinso/remove-remove mldrivers/linux.ml: delete `Remove` commit 91d89a574ee6aeeb7f61c58c9e223fdb29de8459 Author: Cole Robinson <crobinso@redhat.com> Date: Wed Feb 12 16:44:09 2025 -0500 mldrivers/linux.ml: delete `Remove` Last usages were removed in libguestfs/virt-v2v@b3268a1 Signed-off-by: Cole Robinson <crobinso@redhat.com> commit 2bb8c83c1ce5d10d35e5470464e4b9de5034673b Merge: 40bfeed 3831560 Author: rwmjones <rjones@redhat.com> Date: Sun Feb 9 17:33:27 2025 +0000 Merge pull request #6 from rwmjones/RHEL-77989 mldrivers/linux_bootloaders.ml: Don't overwrite EFI grub2 wrapper commit 38315604596ac747e44e38db79496610efee49f8 Author: Richard W.M. Jones <rjones@redhat.com> Date: Thu Feb 6 08:04:38 2025 +0000 mldrivers/linux_bootloaders.ml: Don't overwrite EFI grub2 wrapper Fedora 34+ and RHEL 9.0+ unified BIOS and UEFI grub configuration into a single file. This leaves /boot/efi/EFI/<OS>/grub.cfg as a so-called "wrapper" which just loads the real grub2 configuration at /boot/grub2/grub.cfg. Running '/sbin/grub2-mkconfig -o /boot/efi/EFI/<OS>/grub.cfg' overwrites the wrapper instead of the real configuration file. RHEL 9.5 added a hard error if you try to do this, which broke virt-v2v. The error message was: commandrvf: /sbin/grub2-mkconfig -o /boot/efi/EFI/redhat/grub.cfg Running `grub2-mkconfig -o /boot/efi/EFI/redhat/grub.cfg' will overwrite the GRUB wrapper. Please run `grub2-mkconfig -o /boot/grub2/grub.cfg' instead to update grub.cfg. Try to detect this situation and substitute the real grub configuration file instead. Reported-by: Robert Knipp, Fabian Deutsch Thanks: Nijin Ashok, Marta Lewandowska Fixes: https://issues.redhat.com/browse/RHEL-77989 Related: https://issues.redhat.com/browse/RHEL-32099 Related: https://fedoraproject.org/wiki/Changes/UnifyGrubConfig commit 40bfeed7339b830ce5bd9526599acad36e73f74d Author: Richard W.M. Jones <rjones@redhat.com> Date: Thu Feb 6 08:04:18 2025 +0000 mldrivers/linux_bootloaders.ml: Fix comment style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Trying to work on #1, I used the virt-install output from https://github.com/rwmjones/guestfs-tools/blob/master/builder/templates/ubuntu-20.04.virt-install-cmd. It is not starting in automated mode because it's missing the
ks=/preseed.cfgin the--extra-argsoption.The text was updated successfully, but these errors were encountered: