Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Added ws2812b driver and demo #5

Merged
merged 5 commits into from
Sep 7, 2024
Merged

✨ Added ws2812b driver and demo #5

merged 5 commits into from
Sep 7, 2024

Conversation

50xp50
Copy link
Contributor

@50xp50 50xp50 commented Aug 26, 2024

Closes #4

@kammce kammce self-requested a review August 27, 2024 16:16
kammce
kammce requested changes Aug 27, 2024
View reviewed changes
demos/platforms/lpc4078.cpp Outdated Show resolved Hide resolved
src/ws2812b.cpp Outdated Show resolved Hide resolved
demos/applications/ws2812b.cpp Outdated Show resolved Hide resolved
demos/applications/ws2812b.cpp Outdated Show resolved Hide resolved
demos/applications/ws2812b.cpp Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@kammce kammce changed the title ✨ Added ws2812b driver implementation along with demo ✨ Added ws2812b driver and demo Aug 28, 2024
kammce
kammce requested changes Sep 3, 2024
View reviewed changes
include/libhal-display/ws2812b.hpp Outdated Show resolved Hide resolved
include/libhal-display/ws2812b.hpp Show resolved Hide resolved
include/libhal-display/ws2812b.hpp Outdated Show resolved Hide resolved
include/libhal-display/ws2812b.hpp Outdated Show resolved Hide resolved
src/ws2812b.cpp Outdated Show resolved Hide resolved
include/libhal-display/ws2812b.hpp Outdated Show resolved Hide resolved
demos/applications/ws2812b.cpp Outdated Show resolved Hide resolved
@50xp50 50xp50 marked this pull request as ready for review September 6, 2024 20:54
@50xp50 50xp50 requested a review from kammce September 6, 2024 21:34
kammce
kammce approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@kammce kammce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve that last comment and we can get this merged in.

include/libhal-display/ws2812b.hpp Outdated Show resolved Hide resolved
@kammce kammce merged commit a85f8cc into libhal:main Sep 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kammce kammce kammce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hal::display::ws2812b
2 participants
@50xp50 @kammce