-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please review ibus-hangul test case #96
Conversation
LGTM |
I suggests adding more Hangul input key (and mouse) sequences which had been broken often in ibus+ibus-hangul. I think installed-test is a good way to check such problems automatically. For each test, commit text, preedit text and caret position need to be checked. For example
|
I guess all the test cases can be appended space or Return key to commit the preedit and check the commit string only since users always would commit the preedit finally. I think the current test does not work with mouse so the 4th case would not be implemented. |
I finally tested the PR branch and tried to add some test cases I wanted. But the current test code seems to be limited and works only with 1 Hangul character at a time. It's not easy to adds more tests. For now I agree merging the branch as is. @choehwanjin please just merge it. I'm going to improve it later when I have more time. |
@choehwanjin , Could you merge this pull request? |
Done. Thank you. |
Thanks! |
@choehwanjin Could you release a new version to include this change? |
@fujiwarat This test always fails on my linux system. It should be fixed before release. |
@fujiwarat I was mistaken. I had "preedit-mode" as "none", which caused the test to fail. So it's OK to release. |
Update version to 1.5.4 #96 (comment)
@choehwanjin Thank you! |
Currently we are writing test case for Fedora packages.
This is the test case for ibus-hangul.
Please review the patch, thanks!