Simplify deserialize on Variant!(void, T) #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a special case for Nullable, I also applied this to Variants with void in first place. This is used heavily in serve-d. Additionally it seems Variants don't actually support the serdeEnumProxy properly that's in the here adjusted test. However with Nullable and now with Variant!(void, T) they at least work, which should cover a lot of cases. In serve-d there is only a single exception to this, to which I simply implemented a custom wrapper struct for serialization around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a special case for Nullable, I also applied this to Variants with void in first place. This is used heavily in serve-d.
Additionally it seems Variants don't actually support the serdeEnumProxy properly that was present in the here adjusted test. However with Nullable and now with Variant!(void, T) they at least work, which should cover a lot of cases. In serve-d there is only a single exception to this, to which I simply implemented a custom wrapper struct for serialization around.