Skip to content

Conversation

@wilzbach
Copy link
Member

Pending changes for ndslice from #88

@wilzbach wilzbach mentioned this pull request Apr 14, 2016
@codecov-io
Copy link

Current coverage is 98.12%

Merging #89 into master will not affect coverage as of 62402df

@@            master     #89   diff @@
======================================
  Files            7       7       
  Stmts         2500    2501     +1
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           2453    2454     +1
  Partial          0       0       
  Missed          47      47       

Review entire Coverage Diff as of 62402df

Powered by Codecov. Updated on successful CI builds.

mixin DimensionCTError;
}
{
enum i = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, have you looked at DimensionCTError?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn - i just looked at the first one. My mistake :/

    static assert(dimension < N,
        "dimension = " ~ dimension.stringof ~ " at position "
        ~ i.stringof ~ " should be less than N = " ~ N.stringof
        ~ tailErrorMessage!());

@wilzbach wilzbach force-pushed the fix_style_syntax_ndslice branch from cf0fc8f to 984b622 Compare April 14, 2016 14:49
@9il
Copy link
Member

9il commented Apr 14, 2016

i can not merge this until phobos PR, but i can merge fixes for sum and combinatorics

@wilzbach
Copy link
Member Author

I understood, #88 only contains those. Dscanner will only print a couple of warnings which we can resolve as soon as ndslice is open for changes.

On April 14, 2016 6:10:03 PM GMT+03:00, Ilya Yaroshenko notifications@github.com wrote:

i can not merge this until phobos PR, but i can merge fixes for sum and
las


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#89 (comment)

@wilzbach wilzbach force-pushed the fix_style_syntax_ndslice branch from 984b622 to c1d585a Compare April 14, 2016 18:58
@wilzbach wilzbach force-pushed the fix_style_syntax_ndslice branch from c1d585a to ea340f0 Compare April 18, 2016 10:04
@wilzbach
Copy link
Member Author

This is exactly similar to #154 - closing in favor of the newer PR.

@wilzbach wilzbach closed this Apr 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants