Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change logrus package references to lower case sirupsen #3

Closed
wants to merge 1 commit into from

Conversation

harsh-px
Copy link

@harsh-px harsh-px commented Feb 7, 2018

We need to change all logrus imports to use the lower case Sirupsen to eventually remove hybrid imports (Sirupsen vs sirupsen)

References:

Signed-off-by: Harsh Desai harsh@portworx.com

@harsh-px harsh-px self-assigned this Feb 7, 2018
@ptheunis
Copy link

ptheunis commented Feb 7, 2018

won't this break anyone else pulling gossip in that's using Logrus instead of logrus in other parts of their code?

@harsh-px
Copy link
Author

harsh-px commented Feb 7, 2018

won't this break anyone else pulling gossip in that's using Logrus instead of logrus in other parts of their code?

Yes, it will. However, that is no different from us soon going to update other vendor packages that are using lower case sirupsen (for e.g moby). So we will keep this PR approved and parked here. At one go, we will then push all of these case changes.

On a separate note, I'm fixing the CI failure.

Signed-off-by: Harsh Desai <harsh@portworx.com>
@ptheunis
Copy link

ptheunis commented Feb 7, 2018

Yeah, that looked like a vendoring issue.

@harsh-px
Copy link
Author

harsh-px commented Feb 7, 2018

Will reopen after fixing the build on the branch.

@harsh-px harsh-px closed this Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants