Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move guseggert to alumni #162

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Move guseggert to alumni #162

merged 2 commits into from
Jul 3, 2023

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Jul 3, 2023

Summary

Removing @guseggert from all but alumni team.

@guseggert do you still need permissions beyond what alumni provides?

I guess it goes without saying, but I am more than happy to re-introduce these permissions in case you ever need them again.

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@mxinden mxinden requested review from BigLep and guseggert July 3, 2023 07:09
@mxinden mxinden requested review from a team as code owners July 3, 2023 07:09
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # github_repository_collaborator.this["hydra-booster-infra:guseggert"] will be destroyed
  # (because key ["hydra-booster-infra:guseggert"] is not in for_each map)
  - resource "github_repository_collaborator" "this" {
      - id         = "hydra-booster-infra:guseggert" -> null
      - permission = "admin" -> null
      - repository = "hydra-booster-infra" -> null
      - username   = "guseggert" -> null
    }

  # github_team_membership.this["alumni:guseggert"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "6201424"
      + username = "guseggert"
    }

  # github_team_membership.this["kubo maintainers:guseggert"] will be destroyed
  # (because key ["kubo maintainers:guseggert"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"31943e6c123678d130c8aec6f71f878d0b4bee7dc4678bd197557a3906f2bc2f\"" -> null
      - id       = "7610265:guseggert" -> null
      - role     = "member" -> null
      - team_id  = "7610265" -> null
      - username = "guseggert" -> null
    }

  # github_team_membership.this["w3dt-stewards:guseggert"] will be destroyed
  # (because key ["w3dt-stewards:guseggert"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"f9cab715daa65666013b1cccabf30b660fe13918644b4ab5688d2f92d3d30a5e\"" -> null
      - id       = "4657013:guseggert" -> null
      - role     = "member" -> null
      - team_id  = "4657013" -> null
      - username = "guseggert" -> null
    }

Plan: 1 to add, 0 to change, 3 to destroy.

Copy link

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this wasn't done yet. Is there something we need to improve in our process?

Copy link
Contributor

@galargh galargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be included in offboarding instructions. @BigLep do you know who's responsible for those?

@galargh galargh merged commit 8ef3721 into master Jul 3, 2023
@guseggert
Copy link

@guseggert do you still need permissions beyond what alumni provides?

Nope!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants