-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rust-libp2p): extend required checks #179
Conversation
Extend the list of required GitHub CI actions for the rust-libp2p respository.
Let's wait for @thomaseizinger review here. I am not sure some of these were left out deliberately. |
Before merge, verify that all the following plans are correct. They will be applied as-is after the merge. Terraform planslibp2p
|
github/libp2p.yml
Outdated
files: | ||
.github/workflows/stale.yml: | ||
content: .github/workflows/stale.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already included further down below as an inline file. Why here again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's for a different repo. Resolved here: #180
github/libp2p.yml
Outdated
secret_scanning_push_protection: false | ||
secret_scanning: false | ||
secret_scanning_push_protection: true | ||
secret_scanning: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems unrelated to the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is unrelated. It was automatically committed via "fix rules". It's been resolved separately in #180 and now these changes were removed from the PR.
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
Summary
Extend the list of required GitHub CI actions for the rust-libp2p respository.
Why do you need this?
In order for mergify to not merge pull requests with failing CI.
What else do we need to know?
DRI: myself
Reviewer's Checklist