Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust-libp2p): extend required checks #179

Merged
merged 5 commits into from
Sep 3, 2023
Merged

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Aug 30, 2023

Summary

Extend the list of required GitHub CI actions for the rust-libp2p respository.

Why do you need this?

In order for mergify to not merge pull requests with failing CI.

What else do we need to know?

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

Extend the list of required GitHub CI actions for the rust-libp2p respository.
@mxinden mxinden requested review from a team as code owners August 30, 2023 13:06
@mxinden
Copy link
Member Author

mxinden commented Aug 30, 2023

Let's wait for @thomaseizinger review here. I am not sure some of these were left out deliberately.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # github_branch_protection.this["rust-libp2p:master"] will be updated in-place
  ~ resource "github_branch_protection" "this" {
        id                              = "MDIwOkJyYW5jaFByb3RlY3Rpb25SdWxlMjM0NjQ0MA=="
        # (11 unchanged attributes hidden)

      ~ required_status_checks {
          ~ contexts = [
              + "Compile with MSRV",
              + "Test libp2p-perf",
              + "Test libp2p-server",
              + "Test libp2p-webtransport-websys",
              + "manifest_lint",
                # (54 unchanged elements hidden)
            ]
            # (1 unchanged attribute hidden)
        }

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

github/libp2p.yml Outdated Show resolved Hide resolved
Comment on lines 289 to 291
files:
.github/workflows/stale.yml:
content: .github/workflows/stale.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already included further down below as an inline file. Why here again?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for a different repo. Resolved here: #180

Comment on lines 292 to 296
secret_scanning_push_protection: false
secret_scanning: false
secret_scanning_push_protection: true
secret_scanning: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems unrelated to the PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unrelated. It was automatically committed via "fix rules". It's been resolved separately in #180 and now these changes were removed from the PR.

@galargh galargh merged commit dca922d into master Sep 3, 2023
6 checks passed
@galargh galargh deleted the rust-libp2p-required branch September 3, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants