Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes jxs permissions with rust-libp2p #225

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

dhuseby
Copy link
Contributor

@dhuseby dhuseby commented Mar 21, 2024

Summary

Promotes @jxs to be the active maintainer of rust-libp2p.

Why do you need this?

As the active maintainer, @jxs occasionally needs to do admin things and this fixes that. He's not an org admin, just an admin on rust-libp2p related repos.

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

Signed-off-by: Dave Grantham <dwh@linuxprogrammer.org>
@dhuseby dhuseby requested review from a team as code owners March 21, 2024 02:11
Copy link
Contributor

The following access changes will be introduced as a result of applying the plan:

Access Changes
User galargh:
  - will gain admin permission to rust-libp2p-identity
User jxs:
  - will have the permission to rust-libp2p change from maintain to admin
  - will have the permission to rust-libp2p-identity change from maintain to admin
  - will have the permission to rust-yamux change from maintain to admin

Copy link
Contributor

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  # github_team.this["rust-libp2p active maintainers"] will be updated in-place
  ~ resource "github_team" "this" {
      + create_default_maintainer = false
      + description               = "Active maintainers who need occassional admin over rust-libp2p repos."
        id                        = "9704050"
        name                      = "rust-libp2p Active Maintainers"
        # (5 unchanged attributes hidden)
    }

  # github_team_membership.this["rust-libp2p active maintainers:jxs"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "9704050"
      + username = "jxs"
    }

  # github_team_repository.this["rust-libp2p active maintainers:rust-libp2p"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "admin"
      + repository = "rust-libp2p"
      + team_id    = "9704050"
    }

  # github_team_repository.this["rust-libp2p active maintainers:rust-libp2p-identity"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "admin"
      + repository = "rust-libp2p-identity"
      + team_id    = "9704050"
    }

  # github_team_repository.this["rust-libp2p active maintainers:rust-yamux"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "admin"
      + repository = "rust-yamux"
      + team_id    = "9704050"
    }

Plan: 4 to add, 1 to change, 0 to destroy.

@p-shahi p-shahi merged commit 1bb2c29 into libp2p:master Mar 21, 2024
6 checks passed
@dhuseby dhuseby deleted the rust-libp2p-joao-fixed branch March 24, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants