Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust-libp2p access #252

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

AgeManning
Copy link

@AgeManning AgeManning commented Sep 25, 2024

Summary

I think the access for the rust-libp2p repository is quite out of date and there are various teams scattered in the configuration which are applied inconsistently to various rust-libp2p repositories. Further, Sigma Prime has become a maintainer of the rust-libp2p repository, and this PR updates the github access to reflect this. This is akin to: #245

In summary, this PR

  • Adds a sigma-prime team which has admin rights of the rust-libp2p repository
  • Removes old and redundant rust-libp2p teams
  • Creates a single rust-libp2p-contributors team keeping the active users as members
  • Gives write access to members in the rust-libp2p-contributors team to rust repositories

Why do you need this?

The access for the rust-lib2p repository is out-dated and there are various parties with more access than needed. In order to make this repository secure, and potentially move some CI into Sigma Prime's self-hosted ecosystem, the permissions for this repository need to be tightened to those who actually need them.

What else do we need to know?

This should only effect rust-libp2p and access rights that rust-libp2p maintainers currently posses.

cc @guillaumemichel - You have write access to all rust-libp2p repos. Happy to make a new team of maintainers if you needed higher privileges than write.
cc @jxs - I think I've maintained all current contributors access and removed out-dated contributors, but it might be worth double checking.

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@AgeManning AgeManning requested review from a team as code owners September 25, 2024 06:40
Copy link
Contributor

github-actions bot commented Sep 25, 2024

The following access changes will be introduced as a result of applying the plan:

Access Changes
User 2color:
  - will lose admin permission to rust-libp2p
  - will lose admin permission to rust-yamux
User achingbrain:
  - will have the permission to rust-libp2p change from admin to pull
  - will have the permission to rust-yamux change from admin to pull
User aschmahmann:
  - will lose admin permission to rust-libp2p
  - will lose admin permission to rust-yamux
User dariusc93:
  - will have the permission to rust-libp2p change from admin to push
  - will have the permission to rust-libp2p-identity change from admin to push
  - will have the permission to rust-yamux change from admin to push
  - will gain push permission to blog
  - will gain push permission to demo-multi-lang
  - will gain push permission to notes
  - will gain push permission to projects
  - will gain push permission to test-plans
User dhuseby:
  - will have the permission to rust-libp2p change from admin to pull
  - will have the permission to rust-yamux change from admin to pull
User galargh:
  - will lose admin permission to rust-libp2p
  - will lose admin permission to rust-libp2p-identity
  - will lose admin permission to rust-yamux
User guillaumemichel:
  - will have the permission to rust-libp2p-identity change from maintain to admin
User jbenet:
  - will lose admin permission to rust-libp2p
User jorropo:
  - will lose admin permission to rust-libp2p
  - will lose admin permission to rust-yamux
User kubuxu:
  - will lose admin permission to rust-libp2p
User laurentsenta:
  - will lose admin permission to rust-libp2p
  - will lose admin permission to rust-yamux
User lidel:
  - will lose admin permission to rust-libp2p
  - will lose admin permission to rust-yamux
User marcopolo:
  - will have the permission to rust-libp2p change from admin to push
  - will have the permission to rust-libp2p-identity change from maintain to push
  - will have the permission to rust-yamux change from admin to push
User mxinden:
  - will have the permission to rust-libp2p change from admin to push
  - will have the permission to rust-libp2p-identity change from maintain to push
  - will have the permission to rust-yamux change from admin to push
  - will lose maintain permission to universal-connectivity
User p-shahi:
  - will have the permission to rust-libp2p change from admin to pull
  - will have the permission to rust-yamux change from admin to pull
User raulk:
  - will have the permission to rust-libp2p change from admin to pull
User stebalien:
  - will have the permission to rust-libp2p change from admin to pull
  - will have the permission to rust-yamux change from admin to pull
User sukunrt:
  - will lose admin permission to rust-libp2p
  - will lose admin permission to rust-yamux
User thomaseizinger:
  - will lose admin permission to developer-meetings
  - will lose push permission to docs
  - will have the permission to rust-libp2p change from maintain to push
  - will have the permission to rust-libp2p-identity change from maintain to push
  - will have the permission to rust-yamux change from maintain to push
  - will lose push permission to team-mgmt
  - will lose maintain permission to universal-connectivity
User tomaka:
  - will lose push permission to blog
  - will lose push permission to demo-multi-lang
  - will lose admin permission to developer-meetings
  - will lose push permission to docs
  - will lose push permission to notes
  - will lose push permission to projects
  - will lose push permission to rust-libp2p
  - will lose push permission to rust-yamux
  - will lose push permission to team-mgmt
User vmx:
  - will lose push permission to blog
  - will lose push permission to demo-multi-lang
  - will lose admin permission to developer-meetings
  - will lose push permission to docs
  - will lose push permission to notes
  - will lose push permission to projects
  - will lose push permission to rust-libp2p
  - will lose push permission to rust-yamux
  - will lose push permission to team-mgmt
User yiannisbot:
  - will lose admin permission to rust-libp2p
  - will lose admin permission to rust-yamux

Copy link
Contributor

github-actions bot commented Sep 25, 2024

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # github_team.this["repos - rust"] will be destroyed
  # (because key ["repos - rust"] is not in for_each map)
  - resource "github_team" "this" {
      - description   = "In Rust we tRust " -> null
      - etag          = "W/\"7be8408af4bd0e56f5459dfc4dcf971e77f48be4858495de80d776d1d7361ca5\"" -> null
      - id            = "2457482" -> null
      - members_count = 6 -> null
      - name          = "Repos - Rust" -> null
      - node_id       = "MDQ6VGVhbTI0NTc0ODI=" -> null
      - privacy       = "closed" -> null
      - slug          = "repos-rust" -> null
    }

  # github_team.this["rust-libp2p active maintainers"] will be destroyed
  # (because key ["rust-libp2p active maintainers"] is not in for_each map)
  - resource "github_team" "this" {
      - create_default_maintainer = false -> null
      - description               = "Active maintainers who need occassional admin over rust-libp2p repos." -> null
      - etag                      = "W/\"709c8fda926c091895e89e6a4d1c0aa5d994ac90b66f6e9450a8a9cc6ccad530\"" -> null
      - id                        = "9704050" -> null
      - members_count             = 4 -> null
      - name                      = "rust-libp2p Active Maintainers" -> null
      - node_id                   = "T_kwDOAOJp3s4AlBJy" -> null
      - privacy                   = "closed" -> null
      - slug                      = "rust-libp2p-active-maintainers" -> null
    }

  # github_team.this["rust-libp2p maintainers"] will be destroyed
  # (because key ["rust-libp2p maintainers"] is not in for_each map)
  - resource "github_team" "this" {
      - description   = "Trusted reviewers for merging into rust-libp2p repositories and publishing to crates.io." -> null
      - etag          = "W/\"f9ad6706f99e48befcb2692df1fe5a48109bd1699a51dae2e77ad0dc056ad04c\"" -> null
      - id            = "6797340" -> null
      - members_count = 6 -> null
      - name          = "rust-libp2p Maintainers" -> null
      - node_id       = "T_kwDOAOJp3s4AZ7gc" -> null
      - privacy       = "closed" -> null
      - slug          = "rust-libp2p-maintainers" -> null
    }

  # github_team.this["rust-libp2p-contributors"] will be created
  + resource "github_team" "this" {
      + create_default_maintainer = false
      + description               = "Contributors to the rust-libp2p repository"
      + etag                      = (known after apply)
      + id                        = (known after apply)
      + members_count             = (known after apply)
      + name                      = "rust-libp2p-contributors"
      + node_id                   = (known after apply)
      + privacy                   = "secret"
      + slug                      = (known after apply)
    }

  # github_team.this["rust-libp2p-maintainers"] will be created
  + resource "github_team" "this" {
      + create_default_maintainer = false
      + description               = "Current maintainers of Rust-libp2p"
      + etag                      = (known after apply)
      + id                        = (known after apply)
      + members_count             = (known after apply)
      + name                      = "rust-libp2p-maintainers"
      + node_id                   = (known after apply)
      + privacy                   = "closed"
      + slug                      = (known after apply)
    }

  # github_team_membership.this["repos - rust:agemanning"] will be destroyed
  # (because key ["repos - rust:agemanning"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"d05b03e2e24e531ae453262bc693e0d24734396fe3a602c83e2bffdfabd47f5c\"" -> null
      - id       = "2457482:AgeManning" -> null
      - role     = "member" -> null
      - team_id  = "2457482" -> null
      - username = "AgeManning" -> null
    }

  # github_team_membership.this["repos - rust:jxs"] will be destroyed
  # (because key ["repos - rust:jxs"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"c91294ace49955ed9520780cfa95ec411e1ae4e202c604e461c1c07baca8fef4\"" -> null
      - id       = "2457482:jxs" -> null
      - role     = "member" -> null
      - team_id  = "2457482" -> null
      - username = "jxs" -> null
    }

  # github_team_membership.this["repos - rust:mxinden"] will be destroyed
  # (because key ["repos - rust:mxinden"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"d011bf43d4116ba38b5ac51353c1ee2ed4d30f7c47376dcaabfecfb329d87512\"" -> null
      - id       = "2457482:mxinden" -> null
      - role     = "maintainer" -> null
      - team_id  = "2457482" -> null
      - username = "mxinden" -> null
    }

  # github_team_membership.this["repos - rust:thomaseizinger"] will be destroyed
  # (because key ["repos - rust:thomaseizinger"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"23fda6a54f6fb1b85d26f584c527cfead4bea3b43e660af49347a937a14fc1d6\"" -> null
      - id       = "2457482:thomaseizinger" -> null
      - role     = "member" -> null
      - team_id  = "2457482" -> null
      - username = "thomaseizinger" -> null
    }

  # github_team_membership.this["repos - rust:tomaka"] will be destroyed
  # (because key ["repos - rust:tomaka"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"3dfaf25a204081f65a031762ad11840dbe56edafa2bdc165d47652586a18c828\"" -> null
      - id       = "2457482:tomaka" -> null
      - role     = "maintainer" -> null
      - team_id  = "2457482" -> null
      - username = "tomaka" -> null
    }

  # github_team_membership.this["repos - rust:vmx"] will be destroyed
  # (because key ["repos - rust:vmx"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"705e295b38efd95ecd82896c73c35a6ed17da143881483658b524f7552ec1053\"" -> null
      - id       = "2457482:vmx" -> null
      - role     = "member" -> null
      - team_id  = "2457482" -> null
      - username = "vmx" -> null
    }

  # github_team_membership.this["rust-libp2p active maintainers:agemanning"] will be destroyed
  # (because key ["rust-libp2p active maintainers:agemanning"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"5f70bf10a3a0ae37f0a1485f6c27d97241151323d387b9c628a7da7dd2506e6c\"" -> null
      - id       = "9704050:AgeManning" -> null
      - role     = "member" -> null
      - team_id  = "9704050" -> null
      - username = "AgeManning" -> null
    }

  # github_team_membership.this["rust-libp2p active maintainers:dariusc93"] will be destroyed
  # (because key ["rust-libp2p active maintainers:dariusc93"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"bf4db1799a816274411a0b9dc9dfe7547aa498899d52fe5309318221f5ff70a0\"" -> null
      - id       = "9704050:dariusc93" -> null
      - role     = "member" -> null
      - team_id  = "9704050" -> null
      - username = "dariusc93" -> null
    }

  # github_team_membership.this["rust-libp2p active maintainers:galargh"] will be destroyed
  # (because key ["rust-libp2p active maintainers:galargh"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"9cf285a8caa9065b225bbb61bf91361007b83476eef26cfb6fdca0b8985d3b27\"" -> null
      - id       = "9704050:galargh" -> null
      - role     = "maintainer" -> null
      - team_id  = "9704050" -> null
      - username = "galargh" -> null
    }

  # github_team_membership.this["rust-libp2p active maintainers:jxs"] will be destroyed
  # (because key ["rust-libp2p active maintainers:jxs"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"99b738fe1ed56ea2d2d2a1fef89243cc3b163ae492c1cbae1c33e936fc903b0f\"" -> null
      - id       = "9704050:jxs" -> null
      - role     = "member" -> null
      - team_id  = "9704050" -> null
      - username = "jxs" -> null
    }

  # github_team_membership.this["rust-libp2p maintainers:agemanning"] will be destroyed
  # (because key ["rust-libp2p maintainers:agemanning"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"d16182d2cfacd697f2bf1dad524232810b8addd6ca584573c537bcd795a04cbb\"" -> null
      - id       = "6797340:AgeManning" -> null
      - role     = "member" -> null
      - team_id  = "6797340" -> null
      - username = "AgeManning" -> null
    }

  # github_team_membership.this["rust-libp2p maintainers:guillaumemichel"] will be destroyed
  # (because key ["rust-libp2p maintainers:guillaumemichel"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"04aa8a008478441973531ebf1b09280b75768e69fcdd917f8cb5233bb5ebb0d8\"" -> null
      - id       = "6797340:guillaumemichel" -> null
      - role     = "member" -> null
      - team_id  = "6797340" -> null
      - username = "guillaumemichel" -> null
    }

  # github_team_membership.this["rust-libp2p maintainers:jxs"] will be destroyed
  # (because key ["rust-libp2p maintainers:jxs"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"c78702e08c7d793b2d5f983f79c33ae7b8581417b306f02ac8519e983da443a6\"" -> null
      - id       = "6797340:jxs" -> null
      - role     = "maintainer" -> null
      - team_id  = "6797340" -> null
      - username = "jxs" -> null
    }

  # github_team_membership.this["rust-libp2p maintainers:marcopolo"] will be destroyed
  # (because key ["rust-libp2p maintainers:marcopolo"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"412e01cc3d03afd4ab2df2b48313d619c42325bc633cc9f8ca9172e8346aa3a0\"" -> null
      - id       = "6797340:MarcoPolo" -> null
      - role     = "member" -> null
      - team_id  = "6797340" -> null
      - username = "MarcoPolo" -> null
    }

  # github_team_membership.this["rust-libp2p maintainers:mxinden"] will be destroyed
  # (because key ["rust-libp2p maintainers:mxinden"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"513169e22e51883a7ec41711662f73b4aea71747bb5f6bdf275115595b702aad\"" -> null
      - id       = "6797340:mxinden" -> null
      - role     = "maintainer" -> null
      - team_id  = "6797340" -> null
      - username = "mxinden" -> null
    }

  # github_team_membership.this["rust-libp2p maintainers:thomaseizinger"] will be destroyed
  # (because key ["rust-libp2p maintainers:thomaseizinger"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"691e6004f1c4c4848dcf7122aa7271bd1b94c114291f37692a9519b349e3a06c\"" -> null
      - id       = "6797340:thomaseizinger" -> null
      - role     = "member" -> null
      - team_id  = "6797340" -> null
      - username = "thomaseizinger" -> null
    }

  # github_team_membership.this["rust-libp2p-contributors:dariusc93"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = (known after apply)
      + username = "dariusc93"
    }

  # github_team_membership.this["rust-libp2p-contributors:marcopolo"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = (known after apply)
      + username = "MarcoPolo"
    }

  # github_team_membership.this["rust-libp2p-contributors:mxinden"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = (known after apply)
      + username = "mxinden"
    }

  # github_team_membership.this["rust-libp2p-contributors:thomaseizinger"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = (known after apply)
      + username = "thomaseizinger"
    }

  # github_team_membership.this["rust-libp2p-maintainers:agemanning"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "maintainer"
      + team_id  = (known after apply)
      + username = "AgeManning"
    }

  # github_team_membership.this["rust-libp2p-maintainers:guillaumemichel"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "maintainer"
      + team_id  = (known after apply)
      + username = "guillaumemichel"
    }

  # github_team_membership.this["rust-libp2p-maintainers:jxs"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "maintainer"
      + team_id  = (known after apply)
      + username = "jxs"
    }

  # github_team_repository.this["admin:rust-libp2p"] will be destroyed
  # (because key ["admin:rust-libp2p"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"b791fc8fd99cf9453581cf082274ef6cb2798f0faead4149551e17a80786f680\"" -> null
      - id         = "2077192:rust-libp2p" -> null
      - permission = "admin" -> null
      - repository = "rust-libp2p" -> null
      - team_id    = "2077192" -> null
    }

  # github_team_repository.this["repos - rust:blog"] will be destroyed
  # (because key ["repos - rust:blog"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"580ababfc31877c1f380f06489a3774d35f29ca6b6ac123f700d3431ffc402d1\"" -> null
      - id         = "2457482:blog" -> null
      - permission = "push" -> null
      - repository = "blog" -> null
      - team_id    = "2457482" -> null
    }

  # github_team_repository.this["repos - rust:demo-multi-lang"] will be destroyed
  # (because key ["repos - rust:demo-multi-lang"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"98c09e560621ff17c1a23c5284193370a349bda690362ba9624ae1eb5a115534\"" -> null
      - id         = "2457482:demo-multi-lang" -> null
      - permission = "push" -> null
      - repository = "demo-multi-lang" -> null
      - team_id    = "2457482" -> null
    }

  # github_team_repository.this["repos - rust:developer-meetings"] will be destroyed
  # (because key ["repos - rust:developer-meetings"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"085b7939ba9eb43dc71643609236fc33cc6e1d1d771fbc35ae0645d1fd22bfd6\"" -> null
      - id         = "2457482:developer-meetings" -> null
      - permission = "admin" -> null
      - repository = "developer-meetings" -> null
      - team_id    = "2457482" -> null
    }

  # github_team_repository.this["repos - rust:docs"] will be destroyed
  # (because key ["repos - rust:docs"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"4b929d070dc55c5eb3cb3a1d3cf39099ef2cda91d2cc8720a0fef67a0913a0e5\"" -> null
      - id         = "2457482:docs" -> null
      - permission = "push" -> null
      - repository = "docs" -> null
      - team_id    = "2457482" -> null
    }

  # github_team_repository.this["repos - rust:notes"] will be destroyed
  # (because key ["repos - rust:notes"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"f5b2ac86d432d517c67effce88c65979381285a00cb88386edd8cda2af332877\"" -> null
      - id         = "2457482:notes" -> null
      - permission = "push" -> null
      - repository = "notes" -> null
      - team_id    = "2457482" -> null
    }

  # github_team_repository.this["repos - rust:projects"] will be destroyed
  # (because key ["repos - rust:projects"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"e2360ce0309ea069ff458fa1737e01a47531fb830b5078f3055f417c1c8380ee\"" -> null
      - id         = "2457482:projects" -> null
      - permission = "push" -> null
      - repository = "projects" -> null
      - team_id    = "2457482" -> null
    }

  # github_team_repository.this["repos - rust:rust-libp2p"] will be destroyed
  # (because key ["repos - rust:rust-libp2p"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"6eca54efa38c2f7d0c5397f178fbe6bc979a72dad1f47c816dd8260957b58202\"" -> null
      - id         = "2457482:rust-libp2p" -> null
      - permission = "push" -> null
      - repository = "rust-libp2p" -> null
      - team_id    = "2457482" -> null
    }

  # github_team_repository.this["repos - rust:rust-yamux"] will be destroyed
  # (because key ["repos - rust:rust-yamux"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"a9a37d65fdadfa653a5eda1836feadf216311179b2fdcaf54d29aef1e6710735\"" -> null
      - id         = "2457482:rust-yamux" -> null
      - permission = "push" -> null
      - repository = "rust-yamux" -> null
      - team_id    = "2457482" -> null
    }

  # github_team_repository.this["repos - rust:team-mgmt"] will be destroyed
  # (because key ["repos - rust:team-mgmt"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"a9c976ed4c50f1bad3289e270c45d2b9ac01f17c63a5587b4cef2a1f38e64ead\"" -> null
      - id         = "2457482:team-mgmt" -> null
      - permission = "push" -> null
      - repository = "team-mgmt" -> null
      - team_id    = "2457482" -> null
    }

  # github_team_repository.this["rust-libp2p active maintainers:rust-libp2p"] will be destroyed
  # (because key ["rust-libp2p active maintainers:rust-libp2p"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"b791fc8fd99cf9453581cf082274ef6cb2798f0faead4149551e17a80786f680\"" -> null
      - id         = "9704050:rust-libp2p" -> null
      - permission = "admin" -> null
      - repository = "rust-libp2p" -> null
      - team_id    = "9704050" -> null
    }

  # github_team_repository.this["rust-libp2p active maintainers:rust-libp2p-identity"] will be destroyed
  # (because key ["rust-libp2p active maintainers:rust-libp2p-identity"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"0483b653ca3a94489e35ec235d2336e156c19776fb83eb2dc1163b039a36779b\"" -> null
      - id         = "9704050:rust-libp2p-identity" -> null
      - permission = "admin" -> null
      - repository = "rust-libp2p-identity" -> null
      - team_id    = "9704050" -> null
    }

  # github_team_repository.this["rust-libp2p active maintainers:rust-yamux"] will be destroyed
  # (because key ["rust-libp2p active maintainers:rust-yamux"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"adbf215d90a1c2d120ebad05297457fccd07f6f9001c3c1806e07da21713a8ed\"" -> null
      - id         = "9704050:rust-yamux" -> null
      - permission = "admin" -> null
      - repository = "rust-yamux" -> null
      - team_id    = "9704050" -> null
    }

  # github_team_repository.this["rust-libp2p maintainers:blog"] will be destroyed
  # (because key ["rust-libp2p maintainers:blog"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"580ababfc31877c1f380f06489a3774d35f29ca6b6ac123f700d3431ffc402d1\"" -> null
      - id         = "6797340:blog" -> null
      - permission = "push" -> null
      - repository = "blog" -> null
      - team_id    = "6797340" -> null
    }

  # github_team_repository.this["rust-libp2p maintainers:rust-libp2p"] will be destroyed
  # (because key ["rust-libp2p maintainers:rust-libp2p"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"cd9b6b6a5ac15166f023c588c59241468a127d60cf7c190ff5a2994a3016b25c\"" -> null
      - id         = "6797340:rust-libp2p" -> null
      - permission = "maintain" -> null
      - repository = "rust-libp2p" -> null
      - team_id    = "6797340" -> null
    }

  # github_team_repository.this["rust-libp2p maintainers:rust-libp2p-identity"] will be destroyed
  # (because key ["rust-libp2p maintainers:rust-libp2p-identity"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"580799b2c150a249aea5b53a7c7c6d338091b1998e5291dc4e30a07703221a32\"" -> null
      - id         = "6797340:rust-libp2p-identity" -> null
      - permission = "maintain" -> null
      - repository = "rust-libp2p-identity" -> null
      - team_id    = "6797340" -> null
    }

  # github_team_repository.this["rust-libp2p maintainers:rust-yamux"] will be destroyed
  # (because key ["rust-libp2p maintainers:rust-yamux"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"b9d6766b66da82e4035daa765b75b931184a9c3d13b79dd4de9a01663e9e058d\"" -> null
      - id         = "6797340:rust-yamux" -> null
      - permission = "maintain" -> null
      - repository = "rust-yamux" -> null
      - team_id    = "6797340" -> null
    }

  # github_team_repository.this["rust-libp2p maintainers:test-plans"] will be destroyed
  # (because key ["rust-libp2p maintainers:test-plans"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"d3a0deaf275f664bedc3355cd056ab2d7612ae54e5d223ea715b04e72ecaca5a\"" -> null
      - id         = "6797340:test-plans" -> null
      - permission = "push" -> null
      - repository = "test-plans" -> null
      - team_id    = "6797340" -> null
    }

  # github_team_repository.this["rust-libp2p maintainers:universal-connectivity"] will be destroyed
  # (because key ["rust-libp2p maintainers:universal-connectivity"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"26993fe91fe1b60b8e64b8739a64eb422c449a8511233e2de0abf1f195d0629a\"" -> null
      - id         = "6797340:universal-connectivity" -> null
      - permission = "maintain" -> null
      - repository = "universal-connectivity" -> null
      - team_id    = "6797340" -> null
    }

  # github_team_repository.this["rust-libp2p-contributors:blog"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "blog"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p-contributors:demo-multi-lang"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "demo-multi-lang"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p-contributors:notes"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "notes"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p-contributors:projects"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "projects"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p-contributors:rust-libp2p"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "rust-libp2p"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p-contributors:rust-libp2p-identity"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "rust-libp2p-identity"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p-contributors:rust-yamux"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "rust-yamux"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p-contributors:test-plans"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "test-plans"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p-maintainers:blog"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "blog"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p-maintainers:demo-multi-lang"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "demo-multi-lang"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p-maintainers:developer-meetings"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "admin"
      + repository = "developer-meetings"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p-maintainers:docs"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "docs"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p-maintainers:notes"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "notes"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p-maintainers:projects"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "projects"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p-maintainers:rust-libp2p"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "admin"
      + repository = "rust-libp2p"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p-maintainers:rust-libp2p-identity"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "admin"
      + repository = "rust-libp2p-identity"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p-maintainers:rust-yamux"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "admin"
      + repository = "rust-yamux"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p-maintainers:team-mgmt"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "team-mgmt"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p-maintainers:test-plans"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "test-plans"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p-maintainers:universal-connectivity"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "maintain"
      + repository = "universal-connectivity"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["w3dt-stewards:rust-libp2p"] will be destroyed
  # (because key ["w3dt-stewards:rust-libp2p"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"b791fc8fd99cf9453581cf082274ef6cb2798f0faead4149551e17a80786f680\"" -> null
      - id         = "4657013:rust-libp2p" -> null
      - permission = "admin" -> null
      - repository = "rust-libp2p" -> null
      - team_id    = "4657013" -> null
    }

  # github_team_repository.this["w3dt-stewards:rust-yamux"] will be destroyed
  # (because key ["w3dt-stewards:rust-yamux"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"adbf215d90a1c2d120ebad05297457fccd07f6f9001c3c1806e07da21713a8ed\"" -> null
      - id         = "4657013:rust-yamux" -> null
      - permission = "admin" -> null
      - repository = "rust-yamux" -> null
      - team_id    = "4657013" -> null
    }

Plan: 29 to add, 0 to change, 40 to destroy.

@guillaumemichel
Copy link
Contributor

Thanks for the PR @AgeManning.

Before merging the PR, we need to update the permissions for libp2p crates on crates.io since they depend on the existing Github teams. IMO it would make sense to create a maintainers team to be owner of the libp2p crates, and generally manage the repos settings.

- w3dt-stewards
maintain:
- rust-libp2p Maintainers
- sigma-prime
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AgeManning Thanks for creating this PR but my 2 cents is that I like the abstraction that rust-libp2p Maintainers preserves. If a new full time rust-libp2p maintainer is at Shipyard or other org that's not Sigma Prime, it wouldn't be correct to add that new maintainer to the sigma-prime user group; and because they are a full time maintainer, it wouldn't be correct to add them to rust-libp2p-contributors either.

Wdyt about keeping rust-libp2p Maintainers and having that group consist solely of sigma-prime users?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah for sure.

We are adding new people from sigp in the near future. I thought it might be useful to group them under a sigma-prime banner so it was easier to identify people and change if we no longer become maintainers.

More than happy just to keep it general and rename to rust-libp2p-maintainers.

@AgeManning
Copy link
Author

Thanks for the PR @AgeManning.

Before merging the PR, we need to update the permissions for libp2p crates on crates.io since they depend on the existing Github teams. IMO it would make sense to create a maintainers team to be owner of the libp2p crates, and generally manage the repos settings.

Thanks! I'm assuming these changes need to be done by someone with ownership on crates.io. Not sure how to make those changes.

@guillaumemichel
Copy link
Contributor

@AgeManning, would it be possible to add me to the rust-libp2p-maintainers team? This would allow me to contribute more effectively and increase the bus factor for day-to-day maintenance.

@AgeManning
Copy link
Author

Yep, added you @guillaumemichel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants