Add DNS RR cache #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 14, 2021
lidel
approved these changes
Apr 14, 2021
There was a problem hiding this comment.
TTL handling LGTM.
(I don't like having a single TTL for A and AAAA records, but I don't think this will be a problem in the real world: those will usually be the same, and in case they differ, we pick the lower one, so the end user would not see any stale caches, which is ok.)
I also confirmed the cache speeds up subsequent lookups in patched go-ipfs:
$ time ipfs name resolve /ipns/brave.crypto
/ipfs/QmWrdNJWMbvRxxzLhojVKaBDswS4KNVM7LvjsN7QbDrvka
ipfs name resolve /ipns/brave.crypto 0.22s user 0.01s system 7% cpu 3.070 total
$ time ipfs name resolve /ipns/brave.crypto
/ipfs/QmWrdNJWMbvRxxzLhojVKaBDswS4KNVM7LvjsN7QbDrvka
ipfs name resolve /ipns/brave.crypto 0.03s user 0.02s system 170% cpu 0.030 total
% time ipfs name resolve /ipns/brave.crypto
/ipfs/QmWrdNJWMbvRxxzLhojVKaBDswS4KNVM7LvjsN7QbDrvka
ipfs name resolve /ipns/brave.crypto 0.04s user 0.02s system 177% cpu 0.030 total
Works as expected, thank you @vyzo 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this ensures that we don't do redundant DNS lookups; we do have the TTL after all.