This repository has been archived by the owner on May 11, 2022. It is now read-only.
fix: simplify address replacement #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only ever want to dial the remote peer's observed address (to prevent DoS attacks), so we might as well _always_ replace the reported addresses with the observed address. This also fixes a few issues in the original PR: * Simpler logic. * Replaces the IP address, not the port. That's what we actually care about. * Won't accidentally dial "skipped" protocols (e.g., circuit transport).
willscott
approved these changes
Feb 25, 2021
27 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only ever want to dial the remote peer's observed address (to prevent DoS attacks), so we might as well always replace the reported addresses with the observed address.
This also fixes a few issues in the original PR: