Skip to content
This repository has been archived by the owner on May 11, 2022. It is now read-only.

add a callback for autonat status changes #24

Closed
wants to merge 3 commits into from
Closed

add a callback for autonat status changes #24

wants to merge 3 commits into from

Conversation

whyrusleeping
Copy link

No description provided.

vyzo
vyzo suggested changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have multiple notifiee callbacks, as we want to make a single instance of the service reusable.

@whyrusleeping
Copy link
Author

@vyzo good point, how does that look now?

vyzo
vyzo approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better, thank you!

Kubuxu
Kubuxu reviewed Jun 18, 2019
View reviewed changes
Copy link
Member

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's transition it to the event bus whenever we can.

@raulk
Copy link
Member

raulk commented Jun 25, 2019

We're now doing this via the eventbus: #25.

@raulk raulk closed this Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kubuxu Kubuxu Kubuxu approved these changes

@vyzo vyzo vyzo approved these changes

@Stebalien Stebalien Awaiting requested review from Stebalien

@raulk raulk Awaiting requested review from raulk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whyrusleeping @raulk @vyzo @Kubuxu