This repository has been archived by the owner on Sep 6, 2022. It is now read-only.
feat: keep addresses for longer #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's really no reason to expire these after 10 minutes as opposed to 30. Given that our default DHT refresh interval is 10 minutes, setting this to 30 reduces the chances that we'll "forget" peers.
aschmahmann
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
This seems like a reasonable idea to me. I know peerstore numbers are a bit magical, so I'm not sure if there's other fallout from here.
cc @marten-seemann as a heads up
|
Note: maybe I'm paranoid, but this might be the kind of PR we want to bubble up + test in larger binaries before merging. On the other hand, it's a pretty easy revert if we need to and this kind of change should be fine. |
|
I really doubt this will cause significant issues, honestly. |
|
SGTM |
|
Well, it could affect libp2p/go-libp2p#351. But I don't think it'll make anything much worse. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's really no reason to expire these after 10 minutes as opposed to 30. Given that our default DHT refresh interval is 10 minutes, setting this to 30 reduces the chances that we'll "forget" peers.