This repository has been archived by the owner on Sep 6, 2022. It is now read-only.
fix: switch to go-multicodec mappings #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mappings in go-cid were maintained by hand and are invalid. More details in ipfs/go-cid#137 This is switching to go-multicodec which has correct mappings that are generated, not written by hand.
Co-authored-by: Daniel Martí <mvdan@mvdan.cc>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mappings in go-cid were maintained by hand and are invalid. We want to remove them.
More details in ipfs/go-cid#137
This PR is switching to go-multicodec which has correct mappings that are generated from https://github.com/multiformats/multicodec/blob/master/table.csv, removing the surface for human error.