Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

fix: switch to go-multicodec mappings #240

Merged
merged 2 commits into from
Mar 31, 2022
Merged

fix: switch to go-multicodec mappings #240

merged 2 commits into from
Mar 31, 2022

Conversation

lidel
Copy link
Member

@lidel lidel commented Mar 30, 2022

The mappings in go-cid were maintained by hand and are invalid. We want to remove them.
More details in ipfs/go-cid#137

This PR is switching to go-multicodec which has correct mappings that are generated from https://github.com/multiformats/multicodec/blob/master/table.csv, removing the surface for human error.

The mappings in go-cid were maintained by hand and are invalid.
More details in ipfs/go-cid#137

This is switching to go-multicodec which has correct mappings
that are generated, not written by hand.
Copy link
Contributor

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

peer/peer.go Outdated Show resolved Hide resolved
Co-authored-by: Daniel Martí <mvdan@mvdan.cc>
@lidel lidel merged commit 2a28e1d into master Mar 31, 2022
@lidel lidel deleted the fix/codec-tables branch March 31, 2022 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants