Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

remove the peer.Set #261

Merged
merged 1 commit into from
Jun 22, 2022
Merged

remove the peer.Set #261

merged 1 commit into from
Jun 22, 2022

Conversation

marten-seemann
Copy link
Contributor

@marten-seemann marten-seemann commented Jun 21, 2022 •
edited
Loading

See #260 (comment) for motivation. In addition, this code was completely untested. Yet one more reason to nuke it.

Closes #260.

@github-actions
Copy link

gocompat says:

branch 'master' set up to track 'origin/master'.
"github.com/libp2p/go-libp2p-core/peer".NewSet TopLevelDeclarationDeleted
"github.com/libp2p/go-libp2p-core/peer".Set TopLevelDeclarationDeleted
"github.com/libp2p/go-libp2p-core/peer".NewLimitedSet TopLevelDeclarationDeleted

@marten-seemann marten-seemann mentioned this pull request Jun 21, 2022
Merged
@marten-seemann marten-seemann merged commit b399c77 into master Jun 22, 2022
@marten-seemann marten-seemann mentioned this pull request Jun 27, 2022
Closed
@MarcoPolo MarcoPolo mentioned this pull request Jul 7, 2022
Closed
41 tasks
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
Closed
72 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarcoPolo MarcoPolo MarcoPolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extend peer.Set with the Remove method
2 participants
@marten-seemann @MarcoPolo