This repository has been archived by the owner on May 26, 2022. It is now read-only.
Discovery based Content Routing #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
force-pushed
the
feat/content-routing
branch
from
461551d to
f3be296
Compare
vyzo
reviewed
Sep 8, 2019
| } | ||
|
|
||
| func cidToNs(c cid.Cid) string { | ||
| return "/provider/" + c.String() |
There was a problem hiding this comment.
Perhaps use /cid as the prefix?
There was a problem hiding this comment.
No strong preferences here. /cid is defining based on the key type (CID) and /provider is based on the value type (multiaddr/provider info).
My understanding is that we wanted to get away from advertising CIDs anyway (and instead advertise multihashes) in which case /cid probably isn't the way to go.
@Stebalien thoughts?
There was a problem hiding this comment.
So, @aschmahmann is right. We'd like to move away from advertising CIDs to advertising hashes. Actually, what if we just went ahead and did /content/$multihash from the start? Or /block/$multihash?
bigs
approved these changes
Oct 2, 2019
| } | ||
|
|
||
| func cidToNs(c cid.Cid) string { | ||
| return "/provider/" + c.String() |
Stebalien
approved these changes
Oct 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Discovery and Content Routing interfaces are almost exactly the same as described in libp2p/go-libp2p#707, with Discovery being a more generalized form of Content Routing.
We already have a translator from Content Routing to Discovery. This implements the reverse.
The mock discovery is already in #26, so if that gets merged first it should be removed from here and vice versa. Alternatively, it might make sense to have the mocks in go-libp2p-core/test.