fixup for stream refactor #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
force-pushed
the
feat/refactor
branch
from
afe25f9 to
ca191b4
Compare
|
Instead of disabling the simultaneous connect case, disable reuseport. |
Stebalien
force-pushed
the
feat/refactor
branch
4 times, most recently
from
e058de9 to
17c4190
Compare
72 tasks
Stebalien
force-pushed
the
feat/refactor
branch
from
91fe1e2 to
9231d17
Compare
Stebalien
force-pushed
the
feat/refactor
branch
from
9231d17 to
7076009
Compare
whyrusleeping
approved these changes
Mar 20, 2018
Kubuxu
approved these changes
Mar 20, 2018
Stebalien
force-pushed
the
feat/refactor
branch
from
462ca81 to
b218360
Compare
Stebalien
force-pushed
the
feat/refactor
branch
2 times, most recently
from
54671ce to
f0370e7
Compare
That is, actually wait for the other end to send us an EOF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE (yet)
Part of: libp2p/go-libp2p#297