validate on local put #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, double check the key (should be impossible but the check is cheep).
ghost
assigned 
|
Review request: @dirkmc |
dirkmc
reviewed
Jun 14, 2018
| @@ -177,7 +200,11 @@ func (dht *IpfsDHT) GetValues(ctx context.Context, key string, nvals int) (_ []R | |||
|
|
|||
| // If we have it local, don't bother doing an RPC! | |||
| lrec, err := dht.getLocal(key) | |||
| if err == nil { | |||
| if err != nil { | |||
There was a problem hiding this comment.
Can this if statement include the logic from the one on line 219?
There was a problem hiding this comment.
No... that logic is wrong.
There was a problem hiding this comment.
Yeah it seems a little strange
dirkmc
reviewed
Jun 14, 2018
|
|
||
| byt, ok := v.([]byte) | ||
| if !ok { | ||
| return nil, errors.New("value stored in datastore not []byte") |
There was a problem hiding this comment.
This not []byte error and the unmarshal error below are now going to be logged but the function will return nil in those cases. Whereas for the case where the key does not match ErrNotFound will be returned. Should all three cases return ErrNotFound?
There was a problem hiding this comment.
Yes. Sorry, it should return nil, nil.
…ocal value err is nil in this case
|
@dirkmc fixed. |
|
Nice, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also deduplicates some validation code.