Stream pooling #271
Closed
Stream pooling #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jhiesey
reviewed
Feb 27, 2019
|
GitHub has decided this PR can't be reopened due to my removing |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #92 and #167. It avoids negotiating new streams if there are idle ones, and creates new ones if all current streams are in use. It handles stream failures synchronously, so no notification handling is required. It avoids having to wait for previous requests to complete, and issues with timeouts invalidating streams. It also handles "send-only" messages; arbitrary messages received are detected.
It's a draft, and contains a lot of debugging code still.