Add timeout #351
Merged
Add timeout #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelavila
commented
Jun 14, 2019
| // run it! | ||
| res, err := query.Run(ctx, tablepeers) | ||
| res, err := query.Run(timedCtx, tablepeers) |
There was a problem hiding this comment.
@Stebalien is this what you're talking about?
There was a problem hiding this comment.
Exactly! If we want to get fancy, we could even get the deadline from the context and subtract 1(?) second (we should be connected to the closest peers when this command returns.
Yay for arbitrary constants!
Stebalien
approved these changes
Jun 29, 2019
|
Wait, why don't we just make sure callers pass a timeout? |
whyrusleeping
approved these changes
Jun 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed some odd behavior around the provide call ipfs/go-ipfs-provider#8