Extract validation from ProtocolMessenger #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
commented
Aug 12, 2021
Comment on lines
-599
to
-600
| // GetValues gets nvals values corresponding to the given key. | ||
| func (dht *FullRT) GetValues(ctx context.Context, key string, nvals int) (_ []RecvdVal, err error) { |
There was a problem hiding this comment.
Killed because it was killed in the IpfsDHT implementation and generally isn't very useful #728
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation being done inside the ProtocolMessenger was a bit annoying for anyone trying to utilize the protocol messages more directly (debugging, making an alternative client, etc.).
Additionally, this fixes a bug where even though
WithValidationappeared optional the ProtocolMessenger actually panicked if you didn't pass one in and calledGetValue().