Kbucket refactoring for Content Routing #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarshkshah1992
changed the title
Stebalien
approved these changes
Feb 28, 2020
| count := 0 | ||
| b := rt.buckets[len(rt.buckets)-1] | ||
| for _, p := range b.peerIds() { | ||
| if CommonPrefixLen(rt.local, ConvertPeerID(p)) == int(cpl) { |
There was a problem hiding this comment.
Ouch. We should probably start storing these converted IDs. Sha256 is going to kill us.
There was a problem hiding this comment.
@Stebalien Great point. I never thought about the cost we pay every time we call this function. I've created an issue here:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Stebalien
Optiontype so we can refer to in in the DHT.