This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
Fix memory store signed peer record bug #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
reviewed
Mar 27, 2020
pstoremem/addr_book.go
Outdated
Comment on lines
255
to
257
| if len(amap) == 0 { | ||
| delete(s.signedPeerRecords, p) | ||
| } |
There was a problem hiding this comment.
I'm not sure what the original code was trying to do anyway.
I think for the code to really do what the comment claims to do, it would have to:
- Go through all addresses in the peer record.
- Check if we still have them.
- If we don't, remove the signed record.
This just clears the record if we have no more addresses. But the method that actually adds addresses to a peer shouldn't be the one doing this; it should be done by the GC routine.
There was a problem hiding this comment.
@yusefnapora Do we need to clear this record in addAddrs for some reason ? If not, I can get rid of this code path completely.
There was a problem hiding this comment.
you guys are right; this isn't needed and was likely leftover from when we only had one type of addr. thanks for catching @aarshkshah1992
Stebalien
approved these changes
Mar 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
addrscan very well be nil. However, we should remove the signed peer records entry ONLY if we end up expiring all addresses we Have.