This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
feat: use a clock interface to better support testing for pstoremem #199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary to fix some of the flaky tests in go-libp2p. For example libp2p/go-libp2p#1523 is flaky because we assume that right after we disconnect a peer and check the addrs less than 500ms has elapsed. Of course in a normal environment that's a fine assumption, but in these CI environments relying on things generally happening in a certain amount of time leads to flaky test results.
This also has the added benefit that things don't have to sleep to test the passage of time, they can increment the mock clock. (Didn't update the test suite since I didn't want to update pstoreds version).