fix: fix a busy loop while offline #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If advertising fails, we should wait and retry instead of busy looping. fixes ipfs/kubo#7049
Stebalien
force-pushed
the
fix/busy-loop-offline
branch
from
933dab8 to
30fa75c
Compare
|
CI is broken because CI is broken. |
willscott
approved these changes
Apr 7, 2020
Stebalien
added a commit
that referenced
this pull request
Apr 13, 2020
If advertising fails, we should wait and retry instead of busy looping. fixes ipfs/kubo#7049
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If advertising fails, we should wait and retry instead of busy looping.
fixes ipfs/kubo#7049
(and be extra careful about stopping timers, just because)