Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore transient connections #412

Merged
merged 3 commits into from
Apr 1, 2021
Merged

Ignore transient connections #412

merged 3 commits into from
Apr 1, 2021

Conversation

vyzo
Copy link
Collaborator

@vyzo vyzo commented Apr 1, 2021

So that we don't try to do pubsub over them.

Comment on lines +42 to +50
isTransient := func(pid peer.ID) bool {
for _, c := range p.host.Network().ConnsToPeer(pid) {
if !c.Stat().Transient {
return false
}
}

return true
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah. We really need a better peerstore/database system.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, indeed!

@vyzo
Copy link
Collaborator Author

vyzo commented Apr 1, 2021

rebased on master for merge.

@raulk raulk merged commit e6eff44 into master Apr 1, 2021
@raulk raulk deleted the fix/transient-conns branch April 1, 2021 20:45
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants