Fix appendOrMergeRPC inefficiency in message size recalculation #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
reviewed
Oct 1, 2024
| // maxProtobufOverhead denotes the protobuf encoding overhead for a message. | ||
| // it is based on the RPC.Size function excerpt: | ||
| // l = e.Size() | ||
| // n += 1 + l + sovRpc(uint64(l)) |
There was a problem hiding this comment.
Can you explain where the 1 comes from?
|
Generally looks good. Make sure to run the Fuzz tests as well. A benchmark might also be helpful here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #581 there an inefficiency in
appendOrMergeRPCin callingSize()more times than needed.Fix
Instead of calling
lastRPC.Size()that iterates overRPC.Publish, save the last known size and sum with a current message size and protobuf upper bound overhead.Status and Evaluation
This is draft since there is no performance improvement - TODO.