Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

docs: describe how the limiter is configured, and how limits are scaled #59

Merged
merged 2 commits into from
Jul 3, 2022

Conversation

marten-seemann
Copy link
Contributor

No description provided.

Copy link
Contributor

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm mod minor grammar suggestions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Marco Munizaga <marco@marcopolo.io>
Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is helpful to see written out - thanks. Other things I think I would be curious about as a user:

  1. How to bypass limits
  2. What are the default limits if I do nothing when constructing a ResourceManager (or even better as a user am I always forced to set a Limiter when constructing a ResourceManager thus need to think about this).
  3. If I do always have to create a Limiter, is there a base LimitConfig I can use (and where is it)?
  4. What does the code look like if I like everything about a base LimitConfig but then want to override one specific part of it.


The `FDFraction` defines how many of the file descriptors are allocated to this
scope. In the example above, when called with a file descriptor value of 1000,
this would result in a limit of 1256 file descriptors for the system scope.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did we get to 1256?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants