Increment 'active' counter in swarm dial worker loop

[schomatis]

Not sure where it should be incremented but likely around this case:

go-libp2p-swarm/swarm_dial.go

Lines 476 to 490 in 87ff7ac

	case <-triggerDial:
	for _, addr := range nextDial {
	// spawn the dial
	ad := pending[addr]
	err := s.dialNextAddr(ad.ctx, p, addr, resch)
	if err != nil {
	dispatchError(ad, err)
	}
	}
	nextDial = nil
	triggerDial = nil
	case res := <-resch:
	active--

cc @vyzo

[vyzo]

is there a reason for that? are we missing something? in short, what's the bug?

[schomatis]

I don't have much insight into the code but I think the active variable is a counter that tracks processing dials. When we finish with a dial (we get a response from the dial function) we decrement it, but I didn't see any place where the variable was actually incremented.

[marten-seemann]

@schomatis @vyzo is there anything we need to do here?

[vyzo]

I dont see the bug.

…

On Tue, Dec 21, 2021, 10:37 Marten Seemann ***@***.***> wrote: @schomatis <https://github.com/schomatis> @vyzo <https://github.com/vyzo> is there anything we need to do here? — Reply to this email directly, view it on GitHub <#291 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAI4SS5F34ETQT7GAPLVTTUSA4FLANCNFSM5HOXQ7BQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[vyzo]

but it must be there.

…

On Tue, Dec 21, 2021, 11:01 Dimitris Vyzovitis ***@***.***> wrote: I dont see the bug. On Tue, Dec 21, 2021, 10:37 Marten Seemann ***@***.***> wrote: > @schomatis <https://github.com/schomatis> @vyzo <https://github.com/vyzo> > is there anything we need to do here? > > — > Reply to this email directly, view it on GitHub > <#291 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAI4SS5F34ETQT7GAPLVTTUSA4FLANCNFSM5HOXQ7BQ> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

[vyzo]

See #305 -- I was pretty sure this code was there originally!