This repository has been archived by the owner on May 26, 2022. It is now read-only.
feat: cache interface addresses for 1 minute #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be quite an overhead in cases of high connection rates. The main overhead is thread blocking syscall causing a lot of context switching. License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
vyzo
reviewed
Jun 4, 2019
|
Syscall to fetch all physical interface address called on every request for a swarm address list. |
|
why not cache the addresses completely? |
|
We can, the question is if we want to do it. |
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
|
Updated it to cache whole (RWlocks have a nasty property of contending on one cache line, in cpp they sometimes use distributed RWLocks where reader counts are distributed across many cache lines). |
vyzo
approved these changes
Jun 4, 2019
Stebalien
reviewed
Jun 4, 2019
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Kubuxu
force-pushed
the
feat/cache-interface-addrs
branch
from
bf73c80 to
1b20b7b
Compare
|
Fixed. |
|
This reduced time for the bootstrap of a dht test network (using https://github.com/Kubuxu/go-libp2p-faketransport) by half. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be quite an overhead in cases of high connection rates.
The main overhead is thread blocking syscall causing a lot of context
switching.