This repository has been archived by the owner on May 26, 2022. It is now read-only.
simplify the DialSync code #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
clean-up-dial-sync
branch
from
37e8961
to
49c430f
Compare
Stebalien
requested review from
vyzo and
mxinden
and removed request for
Stebalien
|
Flagging others for review. We need more people who understand this code. |
Stebalien
approved these changes
Sep 7, 2021
It's easier to reason about this code if activeDial doesn't contain a pointer back to DialSync (which already has a map of activeDials). It also allows us to remove the memory footprint of the activeDial struct, so this should be (slightly) more efficient.
marten-seemann
force-pushed
the
clean-up-dial-sync
branch
from
49c430f
to
f8e88bb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easier to reason about this code if
activeDialdoesn't contain a pointer back toDialSync(which already has a map ofactiveDials). It also allows us to remove the memory footprint of theactiveDialstruct, so this should be (slightly) more efficient.No functional change expected.