This repository has been archived by the owner on May 26, 2022. It is now read-only.
read and use the direction from the simultaneous connect context #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Sep 7, 2021
| if simConnect, reason := network.GetSimultaneousConnect(ctx); simConnect { | ||
| dialCtx = network.WithSimultaneousConnect(dialCtx, reason) | ||
| if simConnect, isClient, reason := network.GetSimultaneousConnect(ctx); simConnect { | ||
| dialCtx = network.WithSimultaneousConnect(dialCtx, isClient, reason) |
There was a problem hiding this comment.
We really should have a test for this.
There was a problem hiding this comment.
Yeah, but this has to wait until we have the SecureTransport / SecureMuxer changes in place.
|
go-libp2p-core v0.10.0 has multiple breaking changes, so we can't just use that version without also fixing the other changes. I'll keep this PR as is. Note that it references go-libp2p-core@094b0d3f8ba2, which is a commit on master, so that import path should be safe from garbage collection. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on go-libp2p-core with libp2p/go-libp2p-core#210 merged. Will rebase this PR once v0.10.0 is out.