This repository has been archived by the owner on May 26, 2022. It is now read-only.
add constructor options for timeout, stop using transport.DialTimeout #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
timeout-options
branch
from
e067b52
to
1de208c
Compare
vyzo
reviewed
Dec 19, 2021
| @@ -161,8 +156,9 @@ func newSilentPeer(t *testing.T) (peer.ID, ma.Multiaddr, net.Listener) { | |||
| func TestDialWait(t *testing.T) { | |||
| t.Parallel() | |||
|
|
|||
| ctx := context.Background() | |||
There was a problem hiding this comment.
again here, why are we deopping this context?
There was a problem hiding this comment.
Because it didn't do anything, it's a context.Background().
vyzo
reviewed
Dec 19, 2021
|
Like this: libp2p/go-libp2p#1271 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.