Defer closing stream for reading #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennis-tra
force-pushed
the
master
branch
2 times, most recently
from
f2de233
to
e24c08f
Compare
marten-seemann
approved these changes
May 1, 2021
suites/transport/transport_suite.go
Outdated
| @@ -141,7 +141,7 @@ func SubtestBasic(t *testing.T, ta, tb transport.Transport, maddr ma.Multiaddr, | |||
| t.Fatalf("failed to write enough data (a->b)") | |||
| return | |||
| } | |||
| err = s.Close() | |||
| err = s.CloseWrite() | |||
| if err != nil { | |||
There was a problem hiding this comment.
This could be a one-line if.
suites/transport/transport_suite.go
Outdated
| @@ -155,6 +155,12 @@ func SubtestBasic(t *testing.T, ta, tb transport.Transport, maddr ma.Multiaddr, | |||
| if !bytes.Equal(testData, buf) { | |||
| t.Errorf("expected %s, got %s", testData, buf) | |||
| } | |||
|
|
|||
| err = s.Close() | |||
| if err != nil { | |||
suites/transport/transport_suite.go
Outdated
| @@ -265,7 +271,11 @@ func SubtestPingPong(t *testing.T, ta, tb transport.Transport, maddr ma.Multiadd | |||
| t.Error("failed to write enough data (a->b)") | |||
| return | |||
| } | |||
| s.Close() | |||
| err = s.CloseWrite() | |||
| if err != nil { | |||
suites/transport/transport_suite.go
Outdated
| @@ -276,6 +286,12 @@ func SubtestPingPong(t *testing.T, ta, tb transport.Transport, maddr ma.Multiadd | |||
| if !bytes.Equal(data, ret) { | |||
| t.Errorf("expected %q, got %q", string(data), string(ret)) | |||
| } | |||
|
|
|||
| err = s.Close() | |||
| if err != nil { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I'm trying to bring https://github.com/mtojek/go-libp2p-webrtc-star up to date (fork) and now with updated dependencies, the transport test suite is failing.
I had a look at the test cases and noticed that there are reading attempts on already closed streams. I guess this wasn't a problem until go-libp2p v0.12.0:
In this PR I just deferred closing the reading side.