This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
improve the error message returned when peer verification fails #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Apr 21, 2020
crypto.go
Outdated
| if p, err := peer.IDFromPublicKey(pubKey); err == nil { | ||
| peerID = p | ||
| } | ||
| return fmt.Errorf("peer IDs don't match. Expected %s, got %s", remote, peerID) |
There was a problem hiding this comment.
nit: "peer IDs don't match: expected %s, got %s" but that's mostly just preference.
crypto.go
Outdated
| @@ -93,7 +93,11 @@ func (i *Identity) ConfigForPeer(remote peer.ID) (*tls.Config, <-chan ic.PubKey) | |||
| return err | |||
| } | |||
| if remote != "" && !remote.MatchesPublicKey(pubKey) { | |||
| return errors.New("peer IDs don't match") | |||
| var peerID peer.ID = "(not determined)" | |||
| if p, err := peer.IDFromPublicKey(pubKey); err == nil { | |||
marten-seemann
force-pushed
the
improve-verification-error
branch
from
6b905c5
to
333f6e0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.